Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Nov 2019 00:10:31 +0000
From:      "Foster, Greg" <gfoster@panasas.com>
To:        "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>
Cc:        "Pokala, Ravi" <rpokala@panasas.com>
Subject:   RADIX_MPATH not defined in sys/netinet/ip_input.c on FreeBSD (10.4/12.1)
Message-ID:  <BYAPR08MB6038BDF11AEB428DF69FCEAFB4760@BYAPR08MB6038.namprd08.prod.outlook.com>

next in thread | raw e-mail | index | archive | help
FreeBSD,

I've been looking at some issues related to multipath routing on a system r=
unning FreeBSD 10.4
and came across what looks like a bug/inconsistency in the kernel networkin=
g code.

sys/netinet/ip_output.c:

  *   Includes the "opt_mpath.h" header file via the line  "#include "opt_m=
path.h".


When ip_output.c is compiled the #define RADIX_MPATH will be defined and th=
e code
used will be within the "#ifdef RADIX_MPATH" section of the #ifdef statemen=
t.

sys/netinet/ip_input.c:

  *   Does NOT include the "opt_mpath.h" header file.

When ip_input.c is compiled the #define RADIX_MPATH will NOT be defined and=
 the code
used will be within the "#else" section of the "#ifdef RADIX_MPATH" stateme=
nt.

FreeBSD 12.1 was checked and it has the same inconsistency.

Is this a BUG or is there an explanation why the difference?

Thanks
Greg



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BYAPR08MB6038BDF11AEB428DF69FCEAFB4760>