Date: 01 Apr 2002 04:01:16 -0500 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Joe Marcus Clarke <marcus@marcuscom.com> Cc: Kris Kennaway <kris@obsecurity.org>, Stephen Montgomery-Smith <stephen@math.missouri.edu>, freebsd-ports@FreeBSD.ORG, portmgr@FreeBSD.ORG Subject: Re: [FIX] Argument list too long (was: Argument list too long) Message-ID: <1017651676.89716.7.camel@shumai.marcuscom.com> In-Reply-To: <1017624348.79411.1.camel@shumai.marcuscom.com> References: <3CA7753E.30B37E82@math.missouri.edu> <20020331164956.B14105@xor.obsecurity.org> <1017624348.79411.1.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-ySjYB5PbBAfI+uRjwXXW
Content-Type: multipart/mixed; boundary="=-4G99Zv5rrkQ0kCEvUiXP"
--=-4G99Zv5rrkQ0kCEvUiXP
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2002-03-31 at 20:25, Joe Marcus Clarke wrote:
> On Sun, 2002-03-31 at 19:49, Kris Kennaway wrote:
> > On Sun, Mar 31, 2002 at 02:44:46PM -0600, Stephen Montgomery-Smith wrot=
e:
> > > When building ports, quite often I get messages like this. I don't
> > > suppose that it can be good.
> >=20
> > Are you sure you have an up-to-date bsd.port.mk?
>=20
> The problem is actually with GNOME which has such a long dependency
> list. When ${PKG_ARGS} is built, the actual command line causes sh to
> get a E2BIG. I've been looking at it since last night, but I haven't
> found a good way to process the argument list.
Okay, I'm replying to myself, but I think I've found the problem. The
new bsd.port.mk recursively builds a dependency list. The old one did
this as well, but the new one uses a slightly different style which
causes two variables to grow indefinitely with duplicate info. In any
event, the attached patch fixes the problem, and gets gnome to make
install one second quicker than the previous way ;-).
Kris, should I open a PR for this, or can portmgr@ review the patch from
this email?
Joe
>=20
> Joe
>=20
> >=20
> > Kris
>=20
--=-4G99Zv5rrkQ0kCEvUiXP
Content-Disposition: attachment; filename=bsd.port.mk.diff
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; name=bsd.port.mk.diff; charset=ISO-8859-1
--- bsd.port.mk.orig Mon Apr 1 03:54:09 2002
+++ bsd.port.mk Mon Apr 1 03:53:50 2002
@@ -3154,6 +3154,8 @@
if (${ECHO} $$checked | ${GREP} -qwv "$$dir"); then \
childout=3D$$(cd $$dir; ${MAKE} CHILD_DEPENDS=3Dyes PARENT_CHECKED=3D"=
$$checked" package-depends-list); \
set -- $$childout; \
+ childname=3D""; \
+ childdir=3D""; \
while [ $$\# !=3D 0 ]; do \
childname=3D"$$childname $$1"; \
childdir=3D"$$childdir $$2"; \
--=-4G99Zv5rrkQ0kCEvUiXP--
--=-ySjYB5PbBAfI+uRjwXXW
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iEYEABECAAYFAjyoIdwACgkQb2iPiv4Uz4dj9ACfWaUKH1Lkiok0XQBO1Lz5lEsk
X10AmgIrae+YNfBUFgHIHHXVOjnfnA+3
=w244
-----END PGP SIGNATURE-----
--=-ySjYB5PbBAfI+uRjwXXW--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1017651676.89716.7.camel>