Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Jun 2006 13:06:35 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Tom Rhodes <trhodes@freebsd.org>
Cc:        cvs-src@freebsd.org, cvs-all@freebsd.org, src-committers@freebsd.org, obrien@freebsd.org, "M. Warner Losh" <imp@bsdimp.com>
Subject:   Re: cvs commit: src Makefile README
Message-ID:  <200606211306.36770.jhb@freebsd.org>
In-Reply-To: <20060620193458.42040d97.trhodes@FreeBSD.org>
References:  <200606201516.39121.jhb@freebsd.org> <20060620.155140.-1816810644.imp@bsdimp.com> <20060620193458.42040d97.trhodes@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 20 June 2006 19:34, Tom Rhodes wrote:
> On Tue, 20 Jun 2006 15:51:40 -0600 (MDT)
> "M. Warner Losh" <imp@bsdimp.com> wrote:
> 
> > In message: <200606201714.10331.jhb@freebsd.org>
> >             John Baldwin <jhb@freebsd.org> writes:
> > : On Tuesday 20 June 2006 16:41, M. Warner Losh wrote:
> > : > In message: <200606201516.39121.jhb@freebsd.org>
> > : >             John Baldwin <jhb@freebsd.org> writes:
> > : > : On Tuesday 20 June 2006 14:53, David O'Brien wrote:
> > : > : > On Wed, Jun 07, 2006 at 07:43:00PM -0400, Tom Rhodes wrote:
> > : > : > > Personally, I was debating on just removing most of the
> > : > : > > world target with just a message:
> > : > : > > 
> > : > : > > "The world target has been replaced with the buildworld target."
> > : > : > 
> > : > : > No!
> > : > : > 
> > : > : > 'make world' is still my normal building process.  Why force
> > : > : > "make buildworld && make installworld"??
> > : > : > 
> > : > : > I don't care how undocumented it is, or obfusacted
> > : > : > 'HISTORICAL_MAKE_WORLD' is; but please leave them alone!
> > : > : > 
> > : > : > thanks for your attention.
> > : > : 
> > : > : You can already get that via 'make DESTDIR=/ world' you know. :)  
And 
> > : that's 
> > : > : shorter to type.
> > : > 
> > : > It has been pointed out to me that you can't put DESTDIR=/ in your
> > : > /etc/make.conf file; however, you can put HISTORICAL_MAKE_WORLD=y in
> > : > there.
> > : 
> > : Fair enough.  How about just making it undocumented again then? :)
> > 
> > Works for me.
> 
> Doesn't work here.  Sorry.  It's fine that the options stay
> there, but personally, I can understand why some users would
> be pissed about this being undocumented.  If I started a build
> and expected it to run all night, seen it bombed in the
> morning, well ... Yea, I'd be pissed too.  :)

The nature of the compromise over 'make world' was that rather than removing 
the knob we'd leave it undocumented so that new users aren't tempted to use 
it, but instead will revert to using buildworld/installworld as they ought to 
if they get a failure running 'make world'.  If we are going to document the 
knob and thus make it user-supported, we might as well remove it and just 
make 'make world' user-supported.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200606211306.36770.jhb>