Date: Tue, 27 Mar 2018 02:51:38 -0700 From: Eitan Adler <lists@eitanadler.com> To: Hans Petter Selasky <hps@selasky.org> Cc: Jeff Roberson <jeff@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r331606 - in head/sys: amd64/include i386/include x86/x86 x86/xen Message-ID: <CAF6rxgnoV5FfGE=MwYi29ooMaqzCdXpDspuJ_NEpataQNuh3ZQ@mail.gmail.com> In-Reply-To: <f09ae4a7-6e98-0ed0-53cb-3319dea7d390@selasky.org> References: <201803270337.w2R3b4iv035285@repo.freebsd.org> <f09ae4a7-6e98-0ed0-53cb-3319dea7d390@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27 March 2018 at 01:45, Hans Petter Selasky <hps@selasky.org> wrote:
> On 03/27/18 05:37, Jeff Roberson wrote:
>>
>> do {
>> - current_cpu++;
>> - if (current_cpu > mp_maxid)
>> - current_cpu = 0;
>> - } while (!CPU_ISSET(current_cpu, &intr_cpus));
>> + current_cpu[domain]++;
>> + if (current_cpu[domain] > mp_maxid)
>> + current_cpu[domain] = 0;
>> + } while (!CPU_ISSET(current_cpu[domain], &intr_cpus) ||
>> + !CPU_ISSET(current_cpu[domain], &cpuset_domain[domain]));
>
>
> Can it happen that cpuset_domain[domain] is all zero? Won't this loop hang
> then?
I can replicate the hang. Let me know what other debugging information
you might need.
--
Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgnoV5FfGE=MwYi29ooMaqzCdXpDspuJ_NEpataQNuh3ZQ>