Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Mar 2000 13:43:12 -0700
From:      Warner Losh <imp@village.org>
To:        hackers@freebsd.org
Subject:   Shim Code #error needed
Message-ID:  <200003252043.NAA73526@harmony.village.org>

next in thread | raw e-mail | index | archive | help

I've been burned about 6 times now by the shim device support becoming
optional.  Oh well, that's current.

However, I was thinking that it would be nice if there was something
simple to grep for to see what drivers still needed to be converted.
What would people think of my adding the following to the shim using
devices:

cvs diff: Diffing .
Index: amd.c
===================================================================
RCS file: /home/imp/FreeBSD/CVS/src/sys/pci/amd.c,v
retrieving revision 1.3
diff -u -r1.3 amd.c
--- amd.c       2000/01/14 03:39:30     1.3
+++ amd.c       2000/03/25 18:07:31
@@ -50,6 +50,10 @@
 /* #define AMD_DEBUG0           */
 /* #define AMD_DEBUG_SCSI_PHASE */
 
+#ifndef COMPAT_OLDPCI
+#error "The amd device requires the old pci compatibility shims"
+#endif
+
 #include <sys/param.h>
 
 #include <sys/systm.h>

At least this way you get a decent error message when it fails to
work.

Comments?

Warner


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200003252043.NAA73526>