Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 04 Jul 2015 17:44:30 +0300
From:      Johannes Jost Meixner <xmj@chaot.net>
To:        =?UTF-8?B?VG9yc3RlbiBaw7xobHNkb3JmZg==?= <info@toco-domains.de>,  Torsten Zuehlsdorff <info@toco-domains.de>
Cc:        ruby@freebsd.org, Michael Fausten <michael.fausten@googlemail.com>,  swills@FreeBSD.org, mmoll@FreeBSD.org
Subject:   Re: [Gitlab] Current status (and problem ;)) of the new port
Message-ID:  <5597F14E.4040201@chaot.net>
In-Reply-To: <5597E731.9080308@toco-domains.de>
References:  <ef13628d-e3bf-481c-ad97-987d33e79b98@email.android.com> <5597E731.9080308@toco-domains.de>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Torsten,

this is great news indeed.

On 07/04/2015 17:01, Torsten Zühlsdorff wrote:
> Hello,
> 
>>> Bundler could not find compatible versions for gem "rack": In
>>> Gemfile: rack (>= 1.1) ruby
>>> 
>>> gitlab-grack (>= 2.0.0.rc2) ruby depends on rack (~> 1.5.1)
>>> ruby
>> 
>> 1. Patch the gitlab-grack Gemfile to use
>> 
>> ~> 1.5
> 
> Done! Thanks for the hint. I could not figure out which gem
> triggered this error.
> 
> Now this works, i wrote a PR for the patch: 
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201330
> 
> This is a big step forward! When trying "rake gitlab:setup 
> RAILS_ENV=production" now i "just" got errors about missing 
> configuration. Because i did not configure gitlab. :)
> 
> This means, now this is the first time the new port installs
> correctly and gitlab tries to setup itself :)
> 
> Next week i will test the installation further. There are three
> open tasks: - rc scripts for unicorn-worker

If you create an account on phabricator (https://reviews.freebsd.org)
you can submit the work in progress of the GitLab port via arcanist,
from command line.

The general idea is, when you have an svn/git portstree, you can use
the workflow as described in https://wiki.freebsd.org/CodeReview

Basically, all you have to do is:
1. create an account on reviews.freebsd.org
2. install arcanist -- pkg install php5-arcanist
2a. configure arcanist
3. create a revision.

arc diff --create www/gitlab

now, your $EDITOR opens, and lets you set things:

* set the Revision title to something like:
www/gitlab: Web GUI for managing git repositories

* in the Summary, it's a good idea to yank/paste the revision title,
and then follow that with the entire pkg-descr.

Of course, add yourself as "Submitted by:<tab>Torsten Zühlsdorff"

* in test plan, copypaste the output of `portlint -AC` as well as a
run of poudriere testport [...] -o devel/gitlab.

* as reviewers, #ruby is a good idea (the pound is for teams), and I
think swills, mmoll, sunpoet and I will have opinions on that port
already formed.

Ship it :-)



> - excessive tests ;)

The good thing about the whole exercise with arcanist and uploading it
to phabricator is, obtaining the source code becomes a simple

arc patch D<1234>.

> - make an official installation guide

We'll help you with that if you can put it on a Wiki somewhere (heh,
do you have a public GitLab install?)

All the best,
- -Johannes

> 
> Greetings, Torsten

- -- 
- -xmj
http://xmj.me
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJVl/FJAAoJEPyeKTcbGw0LBGcIALcQDXqKRhNlfgGFOZiPuqUK
D7ynYy5gapWBC/lx0F1BOmKrrdzJLqxP3Xs5W6LVS6RQaIrxb6eOGYGqlRPIujIN
Mt3CidmeLwWrhJEa+nameuypshZeZwdSDF2phB4nKwl6zosBHrSOZRjga/PXwVq4
ny1SM3EdxLgWE0IM4l3uHYDirCsaHnsElqwyM4CG/SRxtWl2v5SGVts92U3Z/iO7
qldVTGWe4lnbl7+Ga2t9Gki4HQwc4ZrJkq29f9pUX1fA/i4WMPJOgZVES+LZK1Na
mV2ykbnXoG1ZnKTkL1o8d4NIvzihO92idwm1QFNRfJms3uw1knWHofeJ/7jR26A=
=Zub8
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5597F14E.4040201>