Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Dec 2016 01:10:51 +0100
From:      Oliver Pinter <oliver.pinter@hardenedbsd.org>
To:        Edward Tomasz Napierala <trasz@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r307774 - head/lib/libusb
Message-ID:  <CAPQ4ffug116y6fLyNzU=m%2Bg-w31WC1gX5Y2frJO-DUGotZMnfw@mail.gmail.com>
In-Reply-To: <CAPQ4ffsna0naq9QMRB9vKGoUpTB%2BPh0dyAzS3uY-W5OYFFV65g@mail.gmail.com>
References:  <201610221437.u9MEbDLR070111@repo.freebsd.org> <CAPQ4ffsna0naq9QMRB9vKGoUpTB%2BPh0dyAzS3uY-W5OYFFV65g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/11/16, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote:
> On 10/22/16, Edward Tomasz Napierala <trasz@freebsd.org> wrote:
>> Author: trasz
>> Date: Sat Oct 22 14:37:13 2016
>> New Revision: 307774
>> URL: https://svnweb.freebsd.org/changeset/base/307774
>>
>> Log:
>>   Fix libusb20_dev_get_desc(3) to use the "vendor product" order, not
>>   "product vendor". This is consistent with how it's generally done.
>>   The ordering is visible eg in usbconfig(8) output.
>>
>>   Note to self: MFC this to 9 and 8.
>>
>>   Reviewed by:	hselasky@
>>   MFC after:	1 month
>
> Is this MFC still valid? I can't see them in 10-STABLE nor in 11-STABLE.
s/can't/not/

>
>>   Differential Revision:	https://reviews.freebsd.org/D8258
>>
>> Modified:
>>   head/lib/libusb/libusb20_ugen20.c
>>
>> Modified: head/lib/libusb/libusb20_ugen20.c
>> ==============================================================================
>> --- head/lib/libusb/libusb20_ugen20.c	Sat Oct 22 13:20:02 2016	(r307773)
>> +++ head/lib/libusb/libusb20_ugen20.c	Sat Oct 22 14:37:13 2016	(r307774)
>> @@ -214,8 +214,8 @@ ugen20_enumerate(struct libusb20_device
>>
>>  	snprintf(pdev->usb_desc, sizeof(pdev->usb_desc),
>>  	    USB_GENERIC_NAME "%u.%u: <%s %s> at usbus%u", pdev->bus_number,
>> -	    pdev->device_address, devinfo.udi_product,
>> -	    devinfo.udi_vendor, pdev->bus_number);
>> +	    pdev->device_address, devinfo.udi_vendor,
>> +	    devinfo.udi_product, pdev->bus_number);
>>
>>  	error = 0;
>>  done:
>> _______________________________________________
>> svn-src-head@freebsd.org mailing list
>> https://lists.freebsd.org/mailman/listinfo/svn-src-head
>> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org"
>>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4ffug116y6fLyNzU=m%2Bg-w31WC1gX5Y2frJO-DUGotZMnfw>