Date: Fri, 23 Feb 2007 05:36:32 GMT From: Matt Jacob <mjacob@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 114849 for review Message-ID: <200702230536.l1N5aWlc013965@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=114849 Change 114849 by mjacob@mjexp on 2007/02/23 05:35:33 Be a bit more restrictive about printing out 'bad' pdb entries during loop rescans. They're not bad so much as unstable, so don't print this stuff out unless ISP_LOGSANCFG is set. Affected files ... .. //depot/projects/mjexp/sys/dev/isp/isp.c#11 edit Differences ... ==== //depot/projects/mjexp/sys/dev/isp/isp.c#11 (text+ko) ==== @@ -2963,17 +2963,19 @@ /* * Check to make sure it's still a valid entry. The 24XX seems * to return a portid but not a WWPN/WWNN or role for devices - * which shift on a loop. + * which shift on a loop, or have a WWPN/WWNN but no portid. */ if (tmp.node_wwn == 0 || tmp.port_wwn == 0 || tmp.portid == 0) { - int a, b, c; - a = (tmp.node_wwn == 0); - b = (tmp.port_wwn == 0); - c = (tmp.portid == 0); - isp_prt(isp, ISP_LOGWARN, - "bad pdb (%1d%1d%1d) @ handle 0x%x", a, b, c, - handle); - isp_dump_portdb(isp); + if (isp->isp_dblev & ISP_LOGSANCFG) { + int a, b, c; + a = !(tmp.node_wwn == 0); + b = !(tmp.port_wwn == 0); + c = !(tmp.portid == 0); + isp_prt(isp, ISP_LOGALL, + "bad pdb (%1d%1d%1d) @ handle 0x%x", + a, b, c, handle); + isp_dump_portdb(isp); + } continue; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200702230536.l1N5aWlc013965>