Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Jul 2011 06:45:08 +0900 (JST)
From:      TAKATSU Tomonari <tota@freebsd.org>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        ruby@freebsd.org
Subject:   [PATCH] devel/rubygem-json*: Add missing dependency on ruby-iconv in Ruby 1.8
Message-ID:  <201107162145.p6GLj8Zr034982@rtfm.jp>

next in thread | raw e-mail | index | archive | help

>Submitter-Id:	current-users
>Originator:	TAKATSU Tomonari
>Organization:	none (private)
>Confidential:	no 
>Synopsis:	[PATCH] devel/rubygem-json*: Add missing dependency on ruby-iconv in Ruby 1.8
>Severity:	non-critical
>Priority:	low
>Category:	ports 
>Class:		change-request
>Release:	FreeBSD 8.2-RELEASE amd64
>Environment:
System: FreeBSD photon.local.lan 8.2-RELEASE FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
>Description:
- Add missing dependency on ruby-iconv in Ruby 1.8
- Bump PORTREVISION

In Ruby 1.8, lib/json/common.rb requires ruby-iconv
because String#encoding has been defined since Ruby 1.9.

See also https://github.com/flori/json/blob/754e3a5f8c2eae225cce70dea5b6f71156990768/lib/json/common.rb#L357

Port maintainer (ruby@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.99
>Fix:

--- rubygem-json-1.5.3_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/rubygem-json/Makefile,v
retrieving revision 1.20
diff -u -u -r1.20 Makefile
--- Makefile    25 Jun 2011 03:13:19 -0000      1.20
+++ Makefile    16 Jul 2011 16:55:55 -0000
@@ -7,6 +7,7 @@

 PORTNAME=	json
 PORTVERSION=	1.5.3
+PORTREVISION=	1
 CATEGORIES=	devel rubygems
 MASTER_SITES=	RG

@@ -18,4 +19,10 @@
 RUBYGEM_AUTOPLIST=	yes
 PLIST_FILES=	bin/edit_json.rb bin/prettify_json.rb

-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${RUBY_VER} < 1.9
+USE_RUBY_FEATURES=	iconv
+.endif
+
+.include <bsd.port.post.mk>
--- rubygem-json-1.5.3_1.patch ends here ---



--- rubygem-json_pure-1.5.3_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/devel/rubygem-json_pure/Makefile,v
retrieving revision 1.14
diff -u -u -r1.14 Makefile
--- Makefile    23 Jun 2011 17:40:29 -0000      1.14
+++ Makefile    16 Jul 2011 16:55:40 -0000
@@ -7,6 +7,7 @@

 PORTNAME=	json_pure
 PORTVERSION=	1.5.3
+PORTREVISION=	1
 CATEGORIES=	devel rubygems
 MASTER_SITES=	RG

@@ -18,4 +19,10 @@
 RUBYGEM_AUTOPLIST=	yes
 PLIST_FILES=	bin/edit_json.rb bin/prettify_json.rb

-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${RUBY_VER} < 1.9
+USE_RUBY_FEATURES=	iconv
+.endif
+
+.include <bsd.port.post.mk>
--- rubygem-json_pure-1.5.3_1.patch ends here ---




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201107162145.p6GLj8Zr034982>