Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 9 Mar 2007 10:22:24 +0300
From:      Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To:        Andrew Thompson <thompsa@freebsd.org>
Cc:        rik@FreeBSD.org, Roman Kurakin <rik@inse.ru>, andre@FreeBSD.org, freebsd-net@freebsd.org, glebius@FreeBSD.org, bms@FreeBSD.org
Subject:   Re: kern/109815: wrong interface identifier at pfil_hooks for vlans +	if_bridge
Message-ID:  <20070309072224.GR58523@codelabs.ru>
In-Reply-To: <20070307210254.GD54828@heff.fud.org.nz>
References:  <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304062203.GL80319@codelabs.ru> <E1HNbWw-000LoF-Bo@pobox.codelabs.ru> <45E9F1E8.2000802@inse.ru> <20070304160613.GN80319@codelabs.ru> <45EDA348.3030309@inse.ru> <20070307210254.GD54828@heff.fud.org.nz>

next in thread | previous in thread | raw e-mail | index | archive | help
> > 
> > +        /* Give a chance for ifp at first priority. This will help in case 
> > we
> > +         * the packet comes through the interface with VLAN's and the same
> > +         * MACs on several interfaces in a bridge. Also will save some 
> > circles
> > +         * in case dst interface is the physical input interface (eq ifp).
> > +         */
> > +        if (ifp->if_type == IFT_GIF
>                ^^^^^^^^^^^^^^^^^^^^^^^
> 	       is this check right?

No, it should read
if (ifp->if_type == IFT_GIF)
	continue;
if (memcmp(IF_LLADDR(.....))) {
	...
}
-- 
Eygene



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070309072224.GR58523>