Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jan 2008 16:34:56 -0500
From:      Tom Rhodes <trhodes@FreeBSD.org>
To:        Juli Mallett <jmallett@FreeBSD.org>
Cc:        src-committers@FreeBSD.org, yar@comp.chem.msu.su, cvs-all@FreeBSD.org, obrien@FreeBSD.org, cvs-src@FreeBSD.org, des@des.no
Subject:   Re: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h
Message-ID:  <20080128163456.4bc7d413.trhodes@FreeBSD.org>
In-Reply-To: <20080128194008.GA55830@toxic.magnesium.net>
References:  <20080127043334.GA75235@dragon.NUXI.org> <20080127053813.GH49535@comp.chem.msu.su> <20080127094653.GA74753@dragon.NUXI.org> <20080128053514.GK49535@comp.chem.msu.su> <86odb6usm6.fsf@ds4.des.no> <20080128161300.GP49535@comp.chem.msu.su> <86prvluc33.fsf@ds4.des.no> <20080128170128.GS49535@comp.chem.msu.su> <20080128182827.GA53020@toxic.magnesium.net> <20080128190705.GU49535@comp.chem.msu.su> <20080128194008.GA55830@toxic.magnesium.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 28 Jan 2008 09:40:09 -1000
Juli Mallett <jmallett@FreeBSD.org> wrote:

> * Yar Tikhiy <yar@comp.chem.msu.su> [ 2008-01-28 ]
> 	[ Re: cvs commit: src UPDATING src/include fts.h src/lib/libc/gen Makefile.inc Symbol.map fts-compat.c fts-compat.h fts.3 fts.c src/sys/sys param.h ]
> > But, hey, have you seen the diffs in the first place?  You seem to
> > assume that my commit was only to kill the innocent int64_t.
> 
> Yes, actually.  I found some of the decisions strange, the work overall
> worthwhile and the "long long" change particularly gauche.  Several others have
> said things that I thought at the time, and I was following the discussion
> closely.  (Your bogus standards reasoning was, in particular, a red flag, and I
> suspect that that caught some people off-guard since your reasoning is
> fallacious and that you would have gotten less grief for the change if you had
> given less strange justifications (even no justifications) initially.)  You said
> that you had received no back-out request, so I made one.  Instead of
> acknowledging that you had now received a single backout request which you would
> not honor (and I was only referring to the "long long" bit, for clarity), you
> chose to grouch that I was rehashing old points (I do not believe backout
> requests should come without reasoning attached.)

I'm not sure I completely agree with a backout but I agree
with changing the types in a follow up commit.

-- 
Tom Rhodes



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080128163456.4bc7d413.trhodes>