Date: Mon, 4 Jun 2018 07:45:00 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Florian Smeets <flo@smeets.xyz> Cc: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334474 - head/usr.bin/top Message-ID: <20180604054500.zqcnqmyuu6mjxn7t@ivaldir.net> In-Reply-To: <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz> References: <201806010551.w515pfoB090926@repo.freebsd.org> <bea6b96c-d312-2c45-ccc2-f6498df5cb2c@smeets.xyz>
next in thread | previous in thread | raw e-mail | index | archive | help
--joi4svscitjrb5vi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 03, 2018 at 07:19:47PM +0200, Florian Smeets via svn-src-all wr= ote: > On 01.06.18 07:51, Eitan Adler wrote: > > Author: eadler > > Date: Fri Jun 1 05:51:40 2018 > > New Revision: 334474 > > URL: https://svnweb.freebsd.org/changeset/base/334474 > >=20 > > Log: > > top(1): Display of TID when using 'H' flag > > =20 > > Some users prefer seeing the TID when viewing individual threads. This > > makes sense as the PID will be the same for multiple entries. An atte= mpt > > was made to include both, but there is insufficient room. As such, us= ing > > the TID. > > =20 > > While here, rename the header variables to be more understandable. > > =20 > > Discussed with: mmacy > > Reported on: 2009-10-07 > >=20 >=20 > Hi, >=20 > I think this is a mistake. The 'H' flag should keep the PID, AFAIK you > cannot use the TID anywhere in top in contrast to the PID. I usually > start top with the 'S' and 'H' flags. Now I cannot use 'k' to kill a > process in that view, as I don't see the PID. IMHO showing TIDs should > be a separate flag, 'h' maybe, as this commit changes current/expected > behavior (POLA?). >=20 > Also, this is not documented in the man page. >=20 > Florian >=20 I fully agrees here! Bapt --joi4svscitjrb5vi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAlsU0dwACgkQY4mL3PG3 Plonfg/+MZeWDrPqcdqdQham5uVBZdGJXqcpPMb4fpxn+RdgNAL+S42+Cq0g0N7K 8/0CT+ewxsiKGoE1pCkFPvmcA2H9hKpFzj+DGAC8TOn12zxvRFU2MC1lsw8OC62O fbsfhysePBpbS4T5y9+9PmnZ7uI/ERPwuzOXmEJ6CKHZkKbTo7NnavocSxT7h0D0 JEtDSW6abMN4XQOm+7584aarPZUdhUqkumA/jf7qpoVlKe2eefSDMuiFUc1CDIBt vF+uX96GIOco+uJ9QGTqoA65akI+ZUE5MDMTRxtRzRth+tYdHKfUSpg+LIrb5M9h XoEDJnKn/ZIvzr3bDscWOm64lNQepJ3dU55K4+cTkEwC76yptPtWV6kM/r29+qWO liOw5qZFPfFX51y2gmZK1M6vQL0oA0qXc1MyrlChoYSeTMBBlFN3g0x8dV84ls/d GYmqHAwh38iqZy21MeZW0PDlUP2r+K8dVNfq9Zws2J2sDY4IRclYbDSWtru/yZW5 FbIv9zZ0+ypm4mLCG0g2gEpxQUpzfAvisl5DxEnFvlFrkI32TM7C+9hrdJC7Q1+Z t0HIbnGSg0mwnHsIsujBbcai/4dyrJxaDaez9T3Naw9e00g36PBEEJ1/h/0zt5Ve IUv7V7V8WqwerF9eUTuL0nH9HDRfMZc7BaZnAeS3+wvjMY8tZeg= =AhVh -----END PGP SIGNATURE----- --joi4svscitjrb5vi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180604054500.zqcnqmyuu6mjxn7t>