Date: Mon, 02 Sep 2002 11:04:20 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Ari Suutari <ari.suutari@syncrontech.com> Cc: Gary Jennejohn <garyj@jennejohn.org>, hselasky@c2i.net, freebsd-isdn@FreeBSD.ORG Subject: Re: New ihfc driver Message-ID: <40894.1030957460@critter.freebsd.dk> In-Reply-To: Your message of "Mon, 02 Sep 2002 09:43:34 %2B0300." <200209020943.34019.ari.suutari@syncrontech.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200209020943.34019.ari.suutari@syncrontech.com>, Ari Suutari writes : >Hi, > >Good that this driver is making progress. Maybe, someday >I can use cards from my pile-of-hfc-based-isdn-cards. > >On Friday 30 August 2002 14:11, Gary Jennejohn wrote: >> hselasky@c2i.net writes: >> >> The stuff you did in the state machines I can't comment on. >> >> The weird dynamic goto's and opaque macros which you use in >> your drivers are IMO not acceptable. If no-one but you understands >> this stuff then we'll have a maintenace nightmare. What if you >> get hit by a truck ? > > A couple of questions come to my mind: > > - if this driver would be added as-is to current distribution, > would it break anything ie. would the worst case be > just that new cards supported by this driver wouldn't work ? I tried, I couldn't get it to compile. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40894.1030957460>