Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 05 Jul 2014 16:04:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 191426] [PATCH] net-mgmt/sendip: Fix package build
Message-ID:  <bug-191426-13-OL63Sli5NL@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-191426-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-191426-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191426

Adam Weinberger <adamw@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Triage                |In Discussion
                 CC|                            |adamw@FreeBSD.org

--- Comment #2 from Adam Weinberger <adamw@FreeBSD.org> ---
For me, that patch BREAKS build, and builds fine without it.

cc -o ripng.so -O2 -pipe -mtune=native -march=native -O2 -pipe
-Qunused-arguments -fstack-protector -fno-strict-aliasing -fPIC -fsigned-char
-pipe -Wall -Wpointer-arith -Wwrite-strings -Wstrict-prototypes
-Wnested-externs -Winline -Werror -Wcast-align
-DSENDIP_LIBS=\"/usr/local/lib/sendip\" -shared ripng.c csum.o compact.o
rip.c:64:38: error: while loop has empty body [-Werror,-Wempty-body]
                while(*(q++)!=':') /* do nothing */; *(--q)='\0';
                                                   ^
rip.c:64:38: note: put the semicolon on a separate line to silence this warning
rip.c:67:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
                                                          ^
rip.c:67:45: note: put the semicolon on a separate line to silence this warning
rip.c:70:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
                                                          ^
rip.c:70:45: note: put the semicolon on a separate line to silence this warning
rip.c:72:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
                                                          ^
rip.c:72:45: note: put the semicolon on a separate line to silence this warning
rip.c:74:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!=':') /* do nothing */; *(--q)='\0';
                                                          ^
rip.c:74:45: note: put the semicolon on a separate line to silence this warning
rip.c:76:46: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!='\0') /* do nothing */; *(--q)='\0';
                                                           ^
rip.c:76:46: note: put the semicolon on a separate line to silence this warning
6 errors generated.
gmake[1]: *** [rip.so] Error 1
gmake[1]: *** Waiting for unfinished jobs....
ripng.c:80:38: error: while loop has empty body [-Werror,-Wempty-body]
                while(*(q++)!='/') /* do nothing */; *(--q)='\0';
                                                   ^
ripng.c:80:38: note: put the semicolon on a separate line to silence this
warning
ripng.c:83:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!='/') /* do nothing */; *(--q)='\0';
                                                          ^
ripng.c:83:45: note: put the semicolon on a separate line to silence this
warning
ripng.c:86:45: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!='/') /* do nothing */; *(--q)='\0';
                                                          ^
ripng.c:86:45: note: put the semicolon on a separate line to silence this
warning
ripng.c:89:46: error: while loop has empty body [-Werror,-Wempty-body]
                p=++q; while(*(q++)!='\0') /* do nothing */; *(--q)='\0';
                                                           ^
ripng.c:89:46: note: put the semicolon on a separate line to silence this
warning
ripng.c:105:18: error: implicit conversion from '__uint16_t' (aka 'unsigned
short') to 'u_int8_t' (aka 'unsigned char') changes value from 4096 to 0
[-Werror,-Wconstant-conversion]
                ripopt->metric=htons((u_int16_t)16);
                              ~^~~~~~~~~~~~~~~~~~~~
/usr/include/netinet/in.h:118:18: note: expanded from macro 'htons'
#define htons(x)        __htons(x)
                        ^~~~~~~~~~
/usr/include/x86/endian.h:127:20: note: expanded from macro '__htons'
#define __htons(x)      __bswap16(x)
                        ^~~~~~~~~~~~
/usr/include/x86/endian.h:74:3: note: expanded from macro '__bswap16'
        ((__uint16_t)(__builtin_constant_p(x) ? \
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
gmake[1]: *** [ripng.so] Error 1
gmake[1]: Leaving directory
`/usr/BUILD-ports/head/net-mgmt/sendip/work/sendip-2.5'

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-191426-13-OL63Sli5NL>