Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Nov 2009 01:35:21 +0000 (UTC)
From:      Marcel Moolenaar <marcel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r199727 - head/sys/ia64/ia64
Message-ID:  <200911240135.nAO1ZLbg087398@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: marcel
Date: Tue Nov 24 01:35:21 2009
New Revision: 199727
URL: http://svn.freebsd.org/changeset/base/199727

Log:
  Improve upon revision 196196 by removing the newly added comment
  in the wrong place and instead add a KASSERT in the right place.

Modified:
  head/sys/ia64/ia64/interrupt.c

Modified: head/sys/ia64/ia64/interrupt.c
==============================================================================
--- head/sys/ia64/ia64/interrupt.c	Mon Nov 23 23:45:26 2009	(r199726)
+++ head/sys/ia64/ia64/interrupt.c	Tue Nov 24 01:35:21 2009	(r199727)
@@ -145,8 +145,6 @@ interrupt(struct trapframe *tf)
 	/*
 	 * Handle ExtINT interrupts by generating an INTA cycle to
 	 * read the vector.
-	 * IPI_STOP_HARD is mapped to IPI_STOP so it is not necessary
-	 * to add it to this switch-like construct.
 	 */
 	if (vector == 0) {
 		inta = ib->ib_inta;
@@ -226,6 +224,10 @@ interrupt(struct trapframe *tf)
 	} else if (vector == ipi_vector[IPI_STOP]) {
 		cpumask_t mybit = PCPU_GET(cpumask);
 
+		/* Make sure IPI_STOP_HARD is mapped to IPI_STOP. */
+		KASSERT(IPI_STOP == IPI_STOP_HARD,
+		    ("%s: IPI_STOP_HARD not handled.", __func__));
+
 		savectx(PCPU_PTR(pcb));
 		atomic_set_int(&stopped_cpus, mybit);
 		while ((started_cpus & mybit) == 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200911240135.nAO1ZLbg087398>