Date: Tue, 14 Jul 2020 17:31:51 +0000 From: Brooks Davis <brooks@freebsd.org> To: Adrian Chadd <adrian@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r363172 - head/contrib/bc/src Message-ID: <20200714173151.GB23830@spindle.one-eyed-alien.net> In-Reply-To: <202007140502.06E52IZn022859@repo.freebsd.org> References: <202007140502.06E52IZn022859@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--gj572EiMnwbLXET9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2020 at 05:02:18AM +0000, Adrian Chadd wrote: > Author: adrian > Date: Tue Jul 14 05:02:18 2020 > New Revision: 363172 > URL: https://svnweb.freebsd.org/changeset/base/363172 >=20 > Log: > [bc] Fix a "maybe uninitialized" compiler warning under mips-gcc-6.3.0. > =20 > I guess this didn't like the case statements.. ? But this does quieten > the compiler error. IMO it would be better to disable this warning for this (old) compiler on this file rather than making a change here (in general we should be removing these sorts of changes). That being said, we need to write down some guidance on this so we have a clear set of principles and we can figure out how we decided which compilers are on which side of the line. -- Brooks --gj572EiMnwbLXET9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJfDewGAAoJEKzQXbSebgfADhkIAIO5tY2875RqsG1Ci2JAX0AH /zhJ8Jl4YSH+4dtzngUopIErLyEiFnL49A/k4q/Fzc/9jxjwDHxGctFluaH2McJZ nPxo8RKJASw4Q/esZfUrVD/A9lkGnFCjUCZKweRphYHgXoq5cOdZMyqDLsfkGzcs sivYDV78BDwn6ygFJ2tQyuwIVg5WfAPR8gWu4cbPn30dYea1ZiV/tHWa8peCLgW2 EAl2/Y6z4Srn99znJl2ji8TqnNLWALLm9e7nJ9IlMG6m1stORws8NhNtriBY7PGZ s6qDWpnCIeRNv5M+AYkRZc1AgVkoNNdPdMLEG/qWa685fpqWTnJ9w3mO7ODhExc= =iDcv -----END PGP SIGNATURE----- --gj572EiMnwbLXET9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200714173151.GB23830>