Date: Sat, 1 Jan 2011 18:00:28 GMT From: "Julian H. Stacey" <jhs@berklix.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/153557: patch to warn birtualbox compiler to unsetenv DISPLAY Message-ID: <201101011800.p01I0SPl027099@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/153557; it has been noted by GNATS. From: "Julian H. Stacey" <jhs@berklix.com> To: Cc: Anonymous <swell.k@gmail.com>, bug-followup@FreeBSD.org, vbox@FreeBSD.org, Bernhard Froehlich <decke@bluelife.at> Subject: Re: ports/153557: patch to warn birtualbox compiler to unsetenv DISPLAY Date: Sat, 01 Jan 2011 18:51:29 +0100 "Julian H. Stacey" wrote: > Anonymous wrote: > > "Julian Stacey" <jhs@berklix.com> writes: > > > > > + test_display != printenv DISPLAY > > > + .if ${test_display} != "" > > > + BROKEN= "unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed request: BadRequest (invalid request code or no such operation)" > > > + .endif > > > + > > > > assignment is redundant here, you can use value from environment directly > > > > .if defined(DISPLAY) && ${DISPLAY} != "" > > Thanks, OK I did a test 8.1-RELEASE amf64 make with DISPLAY set to null string, eg setenv DISPLAY ; make printenv | grep DISPLAY DISPLAY= Result: it builds, thus I confirm your '&& ${DISPLAY} != ""' is also appropriate, Thanks. > > I don't use the port but have you tried CONFIGURE_ARGS+=--passive-mesa ? I added CONFIGURE_ARGS+=--passive-mesa to 8.1-RELEASE i386 /usr/ports/emulators/virtualbox-ose/Makefile printenv | grep DISPLAY # DISPLAY=fire.js.berklix.net:0 Result: it builds OK. Hashing out passive-mesa, make clean ; make fails again. Conclusion: Adding CONFIGURE_ARGS+=--passive-mesa Works better avoids needing BROKEN= But what & where --passive-mesa does, I don't know & if it might damage virtualbox run time I also don't know. Hopefully vbox@FreeBSD.org &/or Bernhard Froehlich <decke@bluelife.at> (cc'd) can decide that. *** old-8.1-RELEASE-and-current/ports/emulators/virtualbox-ose/Makefile Sat Jan 1 18:29:21 2011 --- new-generic/ports/emulators/virtualbox-ose/Makefile Sat Jan 1 18:32:19 2011 *************** *** 24,29 **** --- 24,37 ---- as86:${PORTSDIR}/devel/dev86 \ xsltproc:${PORTSDIR}/textproc/libxslt \ kmk:${PORTSDIR}/devel/kBuild + + # .if defined(DISPLAY) && ${DISPLAY} != "" + # BROKEN= "unsetenv DISPLAY to avoid: Checking for Mesa / GLU: X Error of failed: BadRequest (invalid request code or no such operation)" + # .endif + + CONFIGURE_ARGS+=--passive-mesa + # --passive-mesa To avoid: Checking for Mesa / GLU: X Error of failed: BadRequest (invalid request code or no such operation)" + LIB_DEPENDS= png.6:${PORTSDIR}/graphics/png \ xslt.2:${PORTSDIR}/textproc/libxslt \ curl.6:${PORTSDIR}/ftp/curl Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com Mail plain text; Not quoted-printable, or HTML or base 64. Avoid top posting, it cripples itemised cumulative responses.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201101011800.p01I0SPl027099>