Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Dec 1998 00:16:23 +0100
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Gary Jennejohn <garyj@muc.de>
Cc:        cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.sbin Makefile src/sys/net if_sppp.h if_spppsubr.c src/usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c 
Message-ID:  <84619.914973383@critter.freebsd.dk>
In-Reply-To: Your message of "Tue, 29 Dec 1998 23:48:24 %2B0100." <199812292248.XAA70186@peedub.muc.de> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <199812292248.XAA70186@peedub.muc.de>, Gary Jennejohn writes:
>Poul-Henning Kamp writes:
>>phk         1998/12/27 13:30:50 PST
>>
>>  Modified files:
>>    usr.sbin             Makefile 
>>    sys/net              if_sppp.h if_spppsubr.c 
>>  Added files:
>>    usr.sbin/spppcontrol Makefile spppcontrol.8 spppcontrol.c 
>>  Log:
>>  Update sppp support to i4b level.  This includes the new spppcontrol
>>  program to set PPP options like authentication with.
>>  
>
>what about this code from sppp_ipcp_RCR() in the i4b source ? This actually
>_uses_ gotmyaddr which appears in a few places in the committted code.
>I added this because some ISPs actually send the user's IP address a
>little early.

It was wrong.

It meant that we would steal the other ends IP address.  The address in
an RCR is their address.  We can only get our address from a NAK packet.

If they don't send us our address, we must ask for it by proposing 
0.0.0.0, which they should NAK with the address they want us to use.

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."
"ttyv0" -- What UNIX calls a $20K state-of-the-art, 3D, hi-res color terminal

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?84619.914973383>