Date: Tue, 13 Jan 2009 18:30:03 GMT From: bf <bf2006a@yahoo.com> To: freebsd-multimedia@FreeBSD.org Subject: Re: ports/127468: [PATCH]audio/wavpack: update to 4.50.1 Message-ID: <200901131830.n0DIU32h064932@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/127468; it has been noted by GNATS. From: bf <bf2006a@yahoo.com> To: bug-followup@FreeBSD.org, Christian Weisgerber <naddy@mips.inka.de> Cc: Subject: Re: ports/127468: [PATCH]audio/wavpack: update to 4.50.1 Date: Tue, 13 Jan 2009 10:29:21 -0800 (PST) --- On Mon, 1/12/09, Christian Weisgerber <naddy@mips.inka.de> wrote: > From: Christian Weisgerber <naddy@mips.inka.de> > Subject: Re: ports/127468: [PATCH]audio/wavpack: update to 4.50.1 > To: "bf" <bf2006a@yahoo.com> > Cc: multimedia@FreeBSD.org > Date: Monday, January 12, 2009, 1:58 PM > bf: > > > I have been waiting for some time for > > a response to this PR, after having gone > > to the trouble of submitting it, and now > > I find that the port has been modified, > > and no consideration seems to have been > > given to my suggested changes. > > What happened was that I independently updated > audio/wavpack and > only afterwards accidentally noticed that there had been > PRs open > about it. That's understandable, I've done it myself. But I think that you should have explained why you thought my changes weren't worthwhile, or, better yet, asked me about them, before closing the PR. > > > In particular, the option to use MMX on some > > architectures could speed up encoding, > > and this is still missing from the port. > > Hmm. I've just tried this and there is *no* measurable > speed > difference with and without MMX, both for default encoding > and -hh > -x6. > > hw.machine: amd64 > hw.model: AMD Athlon(tm) 64 X2 Dual Core Processor 5200+ Well, you haven't given me enough information to explain your results. The performance also depends on your compiler, compiler flags, and the data encoded. But I'm guessing that you used gcc > 4, which by default on amd64 exploits SIMD parallelism even when you don't use SIMD intrinsics explicitly in code -- and in this case you have some effective SSE extensions in your hardware. Recall that the default compiler on FreeBSD 6.x is 3.4.6, which doesn't do this nearly as well, and also that not everyone using this port has such a nice computer. And you may not have used high-resolution data. As explained in wavpack's src/pack.c, the MMX option offers an advantage primarily for encoding of > 16-bit audio. My own tests on a uniprocessor 900MHz Athlon using 24-bit WAVs at 44100kHz and 96000kHz show that the MMX option cuts my encoding time by 10-30%. Therefore I think that this build option should be exposed in the port Makefile, whether in an OPTION or just a simple knob, off by default. Regards, b. > > -- > Christian "naddy" Weisgerber > naddy@mips.inka.de
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200901131830.n0DIU32h064932>