Date: Thu, 27 Jul 2000 20:23:22 +0200 (CEST) From: Paul Herman <pherman@frenchfries.net> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/20225: rlogind doesn't compile without -DINET6 (w/patch!) Message-ID: <200007271826.e6RIQI905536@bagabeedaboo.security.at12.de>
next in thread | raw e-mail | index | archive | help
>Number: 20225
>Category: bin
>Synopsis: rlogind doesn't compile without -DINET6
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jul 27 11:30:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Paul Herman
>Release: FreeBSD 4.1-STABLE i386
>Organization:
>Environment:
4.1-STABLE cvsup'ed yesterday.
>Description:
rlogind doesn't compile without -DINET6. I found this by
accident as I was perusing the code.
This is no big deal, as -DINET6 is always (?) defined, but
then again, what's the point of having #ifdefs anyway? :)
>How-To-Repeat:
cd /usr/src/libexec/rlogind
[remove -DINET6 from CFLAGS in Makefile]
make
[error]
>Fix:
Like I said, it's no big deal, but neither is the patch:
------------------------------------------------------------------
--- libexec/rlogind/rlogind.c.orig Thu Jul 27 20:07:37 2000
+++ libexec/rlogind/rlogind.c Thu Jul 27 20:07:57 2000
@@ -231,9 +231,9 @@
hostname[sizeof(hostname) - 1] = '\0';
{
- if ((fromp->su_family != AF_INET &&
+ if ((fromp->su_family != AF_INET
#ifdef INET6
- fromp->su_family != AF_INET6
+ && fromp->su_family != AF_INET6
#endif
) ||
fromp->su_port >= IPPORT_RESERVED ||
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200007271826.e6RIQI905536>