Date: Thu, 27 May 2021 10:57:02 GMT From: Lutz Donnerhacke <donner@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: fb5e2f4d613e - stable/13 - netgraph/ng_bridge: become SMP aware Message-ID: <202105271057.14RAv2Zs099986@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by donner: URL: https://cgit.FreeBSD.org/src/commit/?id=fb5e2f4d613eee6839f25084fdcf078081c080bc commit fb5e2f4d613eee6839f25084fdcf078081c080bc Author: Lutz Donnerhacke <donner@FreeBSD.org> AuthorDate: 2021-01-12 21:28:29 +0000 Commit: Lutz Donnerhacke <donner@FreeBSD.org> CommitDate: 2021-05-27 10:55:44 +0000 netgraph/ng_bridge: become SMP aware The node ng_bridge underwent a lot of changes in the last few months. All those steps were necessary to distinguish between structure modifying and read-only data transport paths. Now it's done, the node can perform frame forwarding on multiple cores in parallel. Differential Revision: https://reviews.freebsd.org/D28123 (cherry picked from commit 9674c2e68c613757ddf5a8780743842b5ac4d74f) --- sys/netgraph/ng_bridge.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/sys/netgraph/ng_bridge.c b/sys/netgraph/ng_bridge.c index 98706cee3a61..0bed50fc240b 100644 --- a/sys/netgraph/ng_bridge.c +++ b/sys/netgraph/ng_bridge.c @@ -351,15 +351,6 @@ ng_bridge_constructor(node_p node) priv->conf.minStableAge = DEFAULT_MIN_STABLE_AGE; priv->sendUnknown = 1; /* classic bridge */ - /* - * This node has all kinds of stuff that could be screwed by SMP. - * Until it gets it's own internal protection, we go through in - * single file. This could hurt a machine bridging between two - * GB ethernets so it should be fixed. - * When it's fixed the process SHOULD NOT SLEEP, spinlocks please! - * (and atomic ops ) - */ - NG_NODE_FORCE_WRITER(node); NG_NODE_SET_PRIVATE(node, priv); priv->node = node;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202105271057.14RAv2Zs099986>