Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Oct 2008 19:23:02 +0000 (UTC)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r183806 - head/sys/fs/portalfs
Message-ID:  <200810121923.m9CJN2F0053444@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: rwatson
Date: Sun Oct 12 19:23:02 2008
New Revision: 183806
URL: http://svn.freebsd.org/changeset/base/183806

Log:
  The locking in portalfs's socket connect code is no less correct than
  identical code in connect(2), so remove XXX that it might be incorrect.
  
  MFC after:	3 days

Modified:
  head/sys/fs/portalfs/portal_vnops.c

Modified: head/sys/fs/portalfs/portal_vnops.c
==============================================================================
--- head/sys/fs/portalfs/portal_vnops.c	Sun Oct 12 19:19:26 2008	(r183805)
+++ head/sys/fs/portalfs/portal_vnops.c	Sun Oct 12 19:23:02 2008	(r183806)
@@ -279,7 +279,6 @@ portal_open(ap)
 	 * will happen if the server dies.  Sleep for 5 second intervals
 	 * and keep polling the reference count.   XXX.
 	 */
-	/* XXXRW: Locking? */
 	SOCK_LOCK(so);
 	while ((so->so_state & SS_ISCONNECTING) && so->so_error == 0) {
 		if (fmp->pm_server->f_count == 1) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810121923.m9CJN2F0053444>