Date: Sat, 08 Aug 2015 07:49:38 +0200 From: Julien Charbon <jch@freebsd.org> To: Mark Johnston <markj@FreeBSD.org>, Larry Rosenman <ler@lerctr.org> Cc: freebsd-current@FreeBSD.org Subject: Re: traceroute6: panic: pcb not read locked Message-ID: <55C59872.8070701@freebsd.org> In-Reply-To: <20150808032521.GA66493@raichu> References: <20150808010324.GA1392@borg.lerctr.org> <20150808032521.GA66493@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9hEdEQ0g6OC6vbiD19qg1KKOA4phNc7We Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 08/08/15 05:25, Mark Johnston wrote: > On Fri, Aug 07, 2015 at 08:04:01PM -0500, Larry Rosenman wrote: >> Trying to debug TimeWarner IPV6 to my HE.NET tunnel, and running trace= route6,=20 >> got the following panic: >> >> borg.lerctr.org dumped core - see /var/crash/vmcore.0 >> >> Fri Aug 7 19:58:40 CDT 2015 >> >> FreeBSD borg.lerctr.org 11.0-CURRENT FreeBSD 11.0-CURRENT #32 r286338:= Wed Aug 5 15:57:55 CDT 2015 root@borg.lerctr.org:/usr/obj/usr/src/s= ys/VT-LER amd64 >> >> panic: Lock tcp not read locked @ /usr/src/sys/netinet/tcp_subr.c:1189= >> >> GNU gdb 6.1.1 [FreeBSD] >> Copyright 2004 Free Software Foundation, Inc. >> GDB is free software, covered by the GNU General Public License, and y= ou are >> welcome to change it and/or distribute copies of it under certain cond= itions. >> Type "show copying" to see the conditions. >> There is absolutely no warranty for GDB. Type "show warranty" for det= ails. >> This GDB was configured as "amd64-marcel-freebsd"... >> >> Unread portion of the kernel message buffer: >> panic: Lock tcp not read locked @ /usr/src/sys/netinet/tcp_subr.c:1189= >=20 > This appears to be fallout from r286227: the tcpinfo lock assertion in > tcp_notify() is too strong, since tcp_notify() can still be called from= > c with the tcpinfo write lock held. Nice catch, I agree these tcpinfo lock assertion are too strong. I am fixing and testing that as in top of tcp_notify() and tcp_drop(), you also need to update also tcp_close() and tcp_detach(). By the way I am working on make INP_INFO_WLOCK a INP_INFO_RLOCK in in6_pcbnotify() but this is not for today. Thanks. -- Julien --9hEdEQ0g6OC6vbiD19qg1KKOA4phNc7We Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVxZh3AAoJEKVlQ5Je6dhxtBQH/i5Kls2bWf2ARkVMY/pPBBY0 Z4sJYcmEgdPsXwRdWqiPy5kXJXKNIaGw2M/vXxZ3V9gsenKc+OaL31gxSmqFwhPO q07M+Bg4JQuLnzN5tgtWkU7GIDGM1Rn/Qpe7M2HpDaq535y/gUkxVaAkeUwK0sAx L2en89SmJUQBAG0pTWoWkzsuyqDg1FsgmkmGA5+RM25+LXhMWwy42a9U9Hdyzenr ag9jz3nDDvYHR+BX8CRazavcXj5MlZZqzHHCU+mTRejw60Dk3iCTtrjm33myHPYp o/UTCqK9Y9FoG678Rm2LD4WE2OGyylFNjLx2mw8lR/+1Lr00J+ZFvmmoYcx1DtY= =FBA2 -----END PGP SIGNATURE----- --9hEdEQ0g6OC6vbiD19qg1KKOA4phNc7We--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55C59872.8070701>