Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 Dec 2010 12:45:55 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Garrett Cooper <gcooper@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Colin Percival <cperciva@FreeBSD.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>
Subject:   Re: svn commit: r216746 - head/sys/conf
Message-ID:  <4D1B8FF3.2040005@bsdimp.com>
In-Reply-To: <AANLkTimmQyr91LDYqB_iSUCzHZQBC5shaof48suJMDWJ@mail.gmail.com>
References:  <201012272352.oBRNqeEb040247@svn.freebsd.org>	<20101228015905.GA81514@troutmask.apl.washington.edu>	<4D194551.7000004@freebsd.org>	<20101228020900.GA81611@troutmask.apl.washington.edu>	<4D1A1EDC.8010603@bsdimp.com> <AANLkTimmQyr91LDYqB_iSUCzHZQBC5shaof48suJMDWJ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12/29/2010 05:00, Garrett Cooper wrote:
> On Tue, Dec 28, 2010 at 9:31 AM, Warner Losh<imp@bsdimp.com>  wrote:
>> On 12/27/2010 19:09, Steve Kargl wrote:
>>> On Mon, Dec 27, 2010 at 06:02:57PM -0800, Colin Percival wrote:
>>>> On 12/27/10 17:59, Steve Kargl wrote:
>>>>> On Mon, Dec 27, 2010 at 11:52:40PM +0000, Colin Percival wrote:
>>>>>>    Make it possible to specify WITHOUT_MODULES in a kernel config file.
>>>>> Can you explain how this differs from
>>>>> makeoptions     NO_MODULES
>>>>> which has been able to do for years?
>>>> NO_MODULES means what it says: No modules.
>>>>
>>>> WITHOUT_MODULES="foo bar baz" means "go ahead and build modules except
>>>> for foo,
>>>> bar, and baz".
>>>>
>>> Thanks.  The distincion wasn't clear from the commit log.
>>> I read it as "Build a kernel WITHOUT building MODULES",
>>> which is what NO_MODULES does.
>> which is why I'd like to have its name changed: it is confusing this way...
>      Wouldn't it be better to have MODULES_EXCLUDE and MODULES_INCLUDE
> or something along those lines? MODULES_OVERRIDE doesn't really have a
> nice clean antonym to go with it according to my friendly neighborhood
> thesaurus.

Yes.  jhb and I have been talking about this, and will have some changes 
soon.

Warner



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D1B8FF3.2040005>