Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Apr 1998 14:19:47 +1000
From:      Bruce Evans <bde@zeta.org.au>
To:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-usrbin@FreeBSD.ORG, phk@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.bin/w w.c
Message-ID:  <199804200419.OAA03435@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>  Modified files:
>    usr.bin/w            w.c 
>  Log:
>  Like most Unices FreeBSD should have a larger tty field at least
>  as large as UT_LINESIZE (/usr/include/utmp.h). If the tty name is logged
>  with this size why isn't the w command reporting it?

To leave as much space as possible for the more interesting `WHAT' field,
and to be consistent with the naming of ttys in ps, etc., where there
is even less space to spare.  In -current where there is more bloat in
the `USER' field, there are now only 22 columns in the `WHAT' field.

>  (We should probably report the tty/cua prefix then as well ? /phk)

We shouldn't.

>  PR:		4187
>  Reviewed by:	phk
>  Submitted by:	Jorge M. Goncalves <ee96199@tom.fe.up.pt>

This shouldn't have been committed.

Other bugs introduced by the PR:
UT_LINESIZE is hard-coded as 8 in HEADER.  See recent PR(?) mail for a
quick fix for the same bug with UT_NAMESIZE.  A proper fix would use
dynamically determined field widths.

Other bugs found while testing this:
`w' didn't link (statically) because someone broke asctime().

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199804200419.OAA03435>