Date: Sun, 15 Jul 2007 18:39:02 +0200 From: Hans Petter Selasky <hselasky@c2i.net> To: freebsd-usb@freebsd.org Cc: Sam Leffler <sam@errno.com> Subject: if_ural.c in FreeBSD 7-current Message-ID: <200707151839.02907.hselasky@c2i.net>
next in thread | raw e-mail | index | archive | help
Hi, Can someone answer me quick on this one: In FreeBSD 7-current, I think I see some mistakes in "if_ural.c". For example: > #define URAL_RSSI(rssi) \ > ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ? \ > ((rssi) - RAL_NOISE_FLOOR + RAL_RSSI_CORR) : 0) Should there be a parenthesis here ?? > #define URAL_RSSI(rssi) \ > ((rssi) > (RAL_NOISE_FLOOR + RAL_RSSI_CORR) ? \ > ((rssi) - (RAL_NOISE_FLOOR + RAL_RSSI_CORR)) : 0) Also I see that the basic rate set is set multiple times: By "set_chan" and when the RUN state is entered! This does not make sense! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200707151839.02907.hselasky>