Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 May 2008 15:03:59 +0400 (MSD)
From:      Dmitry Morozovsky <marck@rinet.ru>
To:        current@FreeBSD.org
Subject:   tunefs: allowing underscores in file system label
Message-ID:  <20080502150037.N40022@woozle.rinet.ru>

next in thread | raw e-mail | index | archive | help
Dear colleagues,

any objection to the following simple patch? It would help using glabel be a 
bit more consistent, as many msdosfs labels contain underscores.

Index: tunefs.c
===================================================================
RCS file: /home/ncvs/src/sbin/tunefs/tunefs.c,v
retrieving revision 1.42
diff -u -r1.42 tunefs.c
--- tunefs.c	9 Apr 2004 19:58:40 -0000	1.42
+++ tunefs.c	2 May 2008 11:00:24 -0000
@@ -139,8 +139,9 @@
 			found_arg = 1;
 			name = "volume label";
 			Lvalue = optarg;
-			i = -1;
-			while (isalnum(Lvalue[++i]));
+			i = 0;
+			while (isalnum(Lvalue[i]) || Lvalue[i] == '_')
+				i++;
 			if (Lvalue[i] != '\0') {
 				errx(10,
 				"bad %s. Valid characters are alphanumerics.",

Sincerely,
D.Marck                                     [DM5020, MCK-RIPE, DM3-RIPN]
[ FreeBSD committer:                                 marck@FreeBSD.org ]
------------------------------------------------------------------------
*** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru ***
------------------------------------------------------------------------



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080502150037.N40022>