Date: Sat, 2 Jan 2021 21:17:16 +0100 (CET) From: Gerald Pfeifer <gerald@pfeifer.com> To: "Sergey A. Osokin" <osa@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r522069 - head/databases/redis-devel Message-ID: <a77eae1-9dc5-8896-5140-24bcdf88198@pfeifer.com> In-Reply-To: <202001042339.004NdRpX083271@repo.freebsd.org> References: <202001042339.004NdRpX083271@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 4 Jan 2020, Sergey A. Osokin wrote:
> +.if ${ARCH} == i386 && ! ${CFLAGS:M-march=*}
> +# Needed for __atomic_fetch_add_8
> +USE_GCC= yes
> +CFLAGS+= -march=i586
> .endif
This has been a while ago, yet I noticed it is still in place.
Are you sure clang does not provide that? GCC 4.2 should not be
an issue on i386 any more since FreeBSD 11 is already on clang.
And the default for current GCC on FreeBSD on i386 already is
i586 since
commit 01a0467e237b69e02f5467babfe2d235c8c68b68
Author: Gerald Pfeifer <gerald@pfeifer.com>
Date: Sun Nov 15 20:03:24 2015 +0000
freebsd.h (SUBTARGET32_DEFAULT_CPU): Change to i586.
* config/i386/freebsd.h (SUBTARGET32_DEFAULT_CPU): Change to i586.
Remove support for FreeBSD 5 and earlier.
so the CFLAGS line definitely should not be required.
Gerald
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a77eae1-9dc5-8896-5140-24bcdf88198>