Date: Wed, 8 Mar 2017 17:33:39 -0800 From: Oleksandr Tymoshenko <gonzo@bluezbox.com> To: Eric van Gyzen <vangyzen@FreeBSD.org> Cc: Adrian Chadd <adrian.chadd@gmail.com>, Matthias Apitz <guru@unixarea.de>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: panic: invalid bcd xxx Message-ID: <20170309013339.GA77488@bluezbox.com> In-Reply-To: <f81dec70-289c-4ef3-69bc-eaa2cdd69ff7@FreeBSD.org> References: <226a00fa-5d04-0aa7-e0cc-6078edde6639@FreeBSD.org> <CAG6CVpXGQds1NYOOd1trYBTE8KNm=VYA3mq9yK3gjjVMt3NNpA@mail.gmail.com> <b753effa-aa7f-ff20-d127-28e1e827f304@FreeBSD.org> <20170301002620.6a5e35ce@bsd64.grem.de> <CAJ-Vmo=-0g7bcU3uq_U0Lc%2B0%2B=-SUiHH02OChjXt=RK6kezDmw@mail.gmail.com> <80EC6EBB-8BF6-4990-9DEE-906EDCE69E06@grem.de> <673e2e0c-b3c8-42b7-a32d-1798eaf571f6@unixarea.de> <CAJ-VmokdNkL6Yn_65in16=E30VZTnmVDMO9Y9BoiEt7M3PvuuA@mail.gmail.com> <20170304174434.GA26923@bluezbox.com> <f81dec70-289c-4ef3-69bc-eaa2cdd69ff7@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Eric van Gyzen (vangyzen@FreeBSD.org) wrote: > On 03/04/2017 11:44, Oleksandr Tymoshenko wrote: > > Adrian Chadd (adrian.chadd@gmail.com) wrote: > >> We're not; we need to cope with crappy BIOS emulations and not crash :) > >> > >> What's Linux doing instead? Ignoring the RTC? > > > > I believe I saw the same problem on either my NUC or Minnowboard. > > I just hacked around it to work on something else and didn't > > have time to get back to the device since then. But it's not > > just emulation BIOS. I think the right way to go is to perform sanity > > check on RTC data and refuse to use it if it's not valid. > > cem@ posted this patch: > > http://dpaste.com/1K2W05E > > If someone can test it, I'll gladly commit it. The real-time clock will > likely be wrong, but it won't panic with INVARIANTS. I can not reproduce crash any more. Probably RTC battery got charged again. I tested this patch with working RTC - there is no regression and patch looks OK functional-wise. -- gonzo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170309013339.GA77488>