Date: Wed, 23 Aug 2017 21:45:50 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Konstantin Belousov <kib@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r322763 - head/lib/libc/amd64/sys Message-ID: <20170824014550.z7su35lezsmfyzw7@mutt-hbsd> In-Reply-To: <201708211739.v7LHdD6k023805@repo.freebsd.org> References: <201708211739.v7LHdD6k023805@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--pf7xt3lyykoqli3k Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 21, 2017 at 05:39:13PM +0000, Konstantin Belousov wrote: > Author: kib > Date: Mon Aug 21 17:39:12 2017 > New Revision: 322763 > URL: https://svnweb.freebsd.org/changeset/base/322763 >=20 > Log: > Optimize libc to get and set TLS using the RDFSBASE and RDGSBASE > instructions, if supported both by CPU and kernel. > =20 > Reviewed by: jhb (previous version) > Tested by: pho (previous version) > Sponsored by: The FreeBSD Foundation > MFC after: 3 weeks > Differential revision: https://reviews.freebsd.org/D12023 >=20 > Added: > head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.c (contents, props ch= anged) > head/lib/libc/amd64/sys/amd64_detect_rdfsgsbase.h (contents, props ch= anged) > Modified: > head/lib/libc/amd64/sys/Makefile.inc > head/lib/libc/amd64/sys/amd64_get_fsbase.c > head/lib/libc/amd64/sys/amd64_get_gsbase.c > head/lib/libc/amd64/sys/amd64_set_fsbase.c > head/lib/libc/amd64/sys/amd64_set_gsbase.c Hey kib, This commit breaks booting in UEFI mode under bhyve. The VM gets stuck when the kernel launches /sbin/init. Here's a screenshot of a verbose boot at a recent HEAD: https://imgur.com/PiJhfll Note, the screenshot depicts HardenedBSD, not FreeBSD. Another user attempting to boot a recent vanilla FreeBSD 12-CURRENT/amd64 snapshot reported to me the same behavior, though, so the issue is certainly not specific to HardenedBSD. Reverting just this commit enabled booting in a bhyve VM again. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --pf7xt3lyykoqli3k Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlmeL8wACgkQaoRlj1JF bu5N/g//bOpZRqzHMIZp5ljqG5McGvfhjHwpUmdxqCLjT2nVEs6+qKjQQP1QnpQV caHrBmwoxhDiXQg7tdFykxBu3gMKMqAYuoM36RUYjcfpSRHQhScUXU67/IhpRaTQ Y2RYsPW7IZ3T4CIeqU3ICgwV1P6hE+Oc3a2oBFYb49ASRiNCXwPYAFY+JzrLKdAl nn0edjdT/ELnA2QfBya7t0PzKtitix8Eelw+fSAwxj3+sDa4kd3BC9zZwlrCHxu+ Y0Sm8Y2N0aSZjEdgJFIoVf4vRJX+OaMpx0tEuGcF6jxysS+nBZYZclyMGS0obdzw iutBaFpa8B8VZa1H6y3GGw1q+IeHfX7VjLHsjnLgr0HM/EyJuVvIczbTzMGcMLE0 c8AxGEr7cNqHyY/Qiex0Dne3cWbsAP00lThTZHJjSV2QMJY+EfaFc5bECvCoqejG EfMQI+L02lduMj6jSLwQRmc7VqyXyeJtS64ZtVTwNUwTf3DNeDcZNnkQn7OTijvb 01accHIHLGMFFAArAE8LJZbAsIk76lDo0pHhcmbY7xH8hZa3TIInHd4DsfI136rZ U08HLWL5RqWS10eRzAR5eoSDHZVH6S42leh08b/j31Sre9X3suPaiCzMzlNlJi5q wqFjRKKmcFfcV540tuWhBP86WpotjJdmZeAj5amIEYL/1VmvXmk= =3J8K -----END PGP SIGNATURE----- --pf7xt3lyykoqli3k--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170824014550.z7su35lezsmfyzw7>