Date: Mon, 9 Feb 2009 11:03:38 -0500 From: Randall Stewart <rrs@lakerest.net> To: Chagin Dmitry <dchagin@freebsd.org>, Paolo Pisati <p.pisati@oltrelinux.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r188388 - head/sys/netinet Message-ID: <32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net> In-Reply-To: <20090209124141.GA2071@dchagin.static.corbina.ru> References: <200902091142.n19BgNnb059032@svn.freebsd.org> <20090209124141.GA2071@dchagin.static.corbina.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Hmm.. My guess is it has to do with the NAT stuff that Paolo is working on. Basically the ipfw/nat is becoming SCTP aware and I believe we made the sctp_crc32c routines public so that he could access them. Paolo: maybe you need to include <opt_sctp.h> and then do some sort of #ifdef SCTP #endif Around the csum calls int crc32?? R On Feb 9, 2009, at 7:41 AM, Chagin Dmitry wrote: > On Mon, Feb 09, 2009 at 11:42:23AM +0000, Randall Stewart wrote: >> Author: rrs >> Date: Mon Feb 9 11:42:23 2009 >> New Revision: 188388 >> URL: http://svn.freebsd.org/changeset/base/188388 >> >> Log: >> Fix minor spacing problem found by s9indent from last >> commit. >> >> Modified: >> head/sys/netinet/sctp_crc32.c >> >> Modified: head/sys/netinet/sctp_crc32.c >> = >> = >> = >> = >> = >> = >> = >> = >> = >> ===================================================================== >> --- head/sys/netinet/sctp_crc32.c Mon Feb 9 11:41:54 2009 (r188387) >> +++ head/sys/netinet/sctp_crc32.c Mon Feb 9 11:42:23 2009 (r188388) >> @@ -729,10 +729,11 @@ sctp_finalize_crc32(uint32_t crc32c) >> #endif >> return (crc32c); >> } >> + >> #else >> uint32_t >> -update_crc32(uint32_t crc32c, unsigned char *buffer, unsigned int >> length) { >> - >> +update_crc32(uint32_t crc32c, unsigned char *buffer, unsigned int >> length) >> +{ >> return (0); >> } >> >> @@ -741,6 +742,7 @@ sctp_finalize_crc32(uint32_t crc32c) >> { >> return (0); >> } >> + >> #endif /* !defined(SCTP_WITH_NO_CSUM) */ >> >> #if defined(SCTP_WITH_NO_CSUM) > > > What would you say about this? (I do not have SCTP option in the > kernel config) > > linking kernel.debug > alias_sctp.o(.text+0x1744): In function `TxAbortErrorM': > /work/pub/head/sys/netinet/libalias/alias_sctp.c:946: undefined > reference to `update_crc32' > alias_sctp.o(.text+0x174b):/work/pub/head/sys/netinet/libalias/ > alias_sctp.c:946: undefined reference to `sctp_finalize_crc32' > *** Error code 1 > > Stop in /tank/obj/work/pub/head/sys/YOY. > *** Error code 1 > > > -- > Have fun! > chd > ------------------------------ Randall Stewart 803-317-4952 (cell) 803-345-0391(direct)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC>