Date: Sun, 24 Dec 2006 20:06:14 -0200 (BRST) From: Sergio Lenzi <lenzi@k1.com.br> To: FreeBSD-gnats-submit@FreeBSD.org Cc: hendrik@scholz.net Subject: ports/107177: [PATCH] multimedia/totem: [SUMMARIZE CHANGES] Message-ID: <200612242206.kBOM6Eui047002@k1.com.br> Resent-Message-ID: <200612242230.kBOMUEcw058023@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 107177
>Category: ports
>Synopsis: [PATCH] multimedia/totem: [SUMMARIZE CHANGES]
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sun Dec 24 22:30:14 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Sergio Lenzi
>Release: FreeBSD 6.1-RELEASE i386
>Organization:
k1 systems
>Environment:
System: FreeBSD gnome.cwb.casa 6.1-RELEASE FreeBSD 6.1-RELEASE #1: Sat Nov 4 17:26:48 BRST
>Description:
[DESCRIBE CHANGES]
When using the xine library to render multimedia,
totem crashes at the end of the render (whe finish)
when closing (shutting donw) the libxine thread.
A look at the xine code, shows no need to call
garbage-collector, so a patch was done to
not call it at the end of totem run.
Port maintainer (hendrik@scholz.net) is cc'd.
Generated with FreeBSD Port Tools 0.77
Added file(s):
- files/patch-xine
Port maintainer (hendrik@scholz.net) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
compile totem with xine support (not using gstreamer).
and run against any multimedia file (.avi,.mov,....)
when closing totem, it aborts
>Fix:
recompile totem with a fix to not
call garbage-collector in the libxine module
--- totem-2.16.2_2.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/multimedia/totem/files/patch-xine /tmp/totem/files/patch-xine
--- /usr/ports/multimedia/totem/files/patch-xine Wed Dec 31 21:00:00 1969
+++ /tmp/totem/files/patch-xine Mon Dec 11 05:25:24 2006
@@ -0,0 +1,29 @@
+--- src/backend/bacon-video-widget-xine.c.orig Mon Dec 11 04:32:05 2006
++++ src/backend/bacon-video-widget-xine.c Mon Dec 11 05:18:25 2006
+@@ -467,7 +467,7 @@
+ g_object_unref (G_OBJECT (bvw->priv->gc));
+
+ if (bvw->priv->xine != NULL) {
+- xine_plugins_garbage_collector (bvw->priv->xine);
++// xine_plugins_garbage_collector (bvw->priv->xine);
+ xine_exit (bvw->priv->xine);
+ bvw->priv->xine = NULL;
+ }
+@@ -1670,7 +1670,7 @@
+ bvw->priv->ao_driver);
+
+ /* stop event thread */
+- xine_plugins_garbage_collector (bvw->priv->xine);
++// xine_plugins_garbage_collector (bvw->priv->xine);
+ xine_exit (bvw->priv->xine);
+ bvw->priv->xine = NULL;
+
+@@ -2181,7 +2181,7 @@
+ err = xine_open (bvw->priv->stream, mrl);
+ }
+
+- xine_plugins_garbage_collector (bvw->priv->xine);
++// xine_plugins_garbage_collector (bvw->priv->xine);
+
+ if (err == 0)
+ {
--- totem-2.16.2_2.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612242206.kBOM6Eui047002>