Date: Thu, 3 Sep 2009 22:15:48 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Attilio Rao <attilio@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r196779 - in head/sys: kern sys Message-ID: <20090903191548.GJ1881@deviant.kiev.zoral.com.ua> In-Reply-To: <200909031340.n83Defkv034013@svn.freebsd.org> References: <200909031340.n83Defkv034013@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--kLVHNs1Bw8OEK8QD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 03, 2009 at 01:40:41PM +0000, Attilio Rao wrote: > Author: attilio > Date: Thu Sep 3 13:40:41 2009 > New Revision: 196779 > URL: http://svn.freebsd.org/changeset/base/196779 >=20 > Log: > Add intermediate states for attaching and detaching that will be > reused by the enhached newbus locking once it is checked in. > This change can be easilly MFCed to STABLE_8 at the appropriate moment. > =20 > Reviewed by: jhb, scottl > Tested by: Giovanni Trematerra <giovanni dot trematerra at gmail dot co= m> >=20 =2E... > Modified: head/sys/sys/bus.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/bus.h Thu Sep 3 12:41:00 2009 (r196778) > +++ head/sys/sys/bus.h Thu Sep 3 13:40:41 2009 (r196779) > @@ -52,8 +52,11 @@ struct u_businfo { > typedef enum device_state { > DS_NOTPRESENT, /**< @brief not probed or probe failed */ > DS_ALIVE, /**< @brief probe succeeded */ > + DS_ATTACHING, /**< @brief attaching is in progress */ > DS_ATTACHED, /**< @brief attach method called */ > - DS_BUSY /**< @brief device is open */ > + DS_BUSY, /**< @brief device is open */ > + DS_DETACHING /**< @brief detaching is in progress */ > + > } device_state_t; Since device_state_t is exposed to consumers and started to be modified, would it make sense to add explicit values for enumeration members, with enough gap in between ? It seems to give more freedom for newbus locking work with regard to backward-compatible ABI changes. --kLVHNs1Bw8OEK8QD Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkqgFeQACgkQC3+MBN1Mb4gZkACgkT0igWmErBrn5RWj3PWwB4fb eA4An1KDW5QAwjVRhGr2w9PMaMge2LXQ =2xZu -----END PGP SIGNATURE----- --kLVHNs1Bw8OEK8QD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090903191548.GJ1881>