Date: Sun, 22 Dec 2002 10:07:48 +0000 From: Dima Dorfman <dima@trit.org> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/etc rc.diskless1 Message-ID: <20021222100748.GC12728@trit.org> In-Reply-To: <200212212038.gBLKcFUY075250@apollo.backplane.com> References: <200212210030.gBL0U8mj092252@repoman.freebsd.org> <20021221051202.A19933@locore.ca> <200212212038.gBLKcFUY075250@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Dillon <dillon@apollo.backplane.com> wrote: > Ok, I hit a problem with the RCNG stuff. The problem is that reloading > the rc.conf files is not enough... RCNG unconditionally loads the original > (incorrect) rc.conf file before it runs any scripts. > > This creates massive leakage from the server's own rc.conf's into the > diskless client's rc.conf's. As the one who originally fixed this in rcng with the hack you described, I like your solution much better. One comment, though: > Index: rc.d/rcconf > =================================================================== > RCS file: rc.d/rcconf > diff -N rc.d/rcconf > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ rc.d/rcconf 21 Dec 2002 20:30:50 -0000 > @@ -0,0 +1,10 @@ > +#!/bin/sh > +# > +# $FreeBSD$ > +# > + > +# PROVIDE: rcconf > +# REQUIRE: initdiskless > +# KEYWORD: FreeBSD NetBSD > + > +load_rc_config 'XXX' Are you sure this actually works? I believe this script will be run in a subshell, which will not cause the rc.conf stuff loaded here to be propogated to the parent shell. See the comment above run_rc_script() in rc.subr. If I'm wrong about this (it's been a while since I looked at the rcng stuff--it might have changed, or I might not remember the details), please ignore the above paragraph (but not the one above it) :-). Thanks for taking the time to clean this up. Dima. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021222100748.GC12728>