Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Feb 2014 19:49:49 +0100
From:      Tijl Coosemans <tijl@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r345514 - head/Mk/Uses
Message-ID:  <20140221194949.29595e47@kalimero.tijl.coosemans.org>
In-Reply-To: <201402211647.s1LGlTuw053335@svn.freebsd.org>
References:  <201402211647.s1LGlTuw053335@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote:
> Author: bapt
> Date: Fri Feb 21 16:47:29 2014
> New Revision: 345514
> URL: http://svnweb.freebsd.org/changeset/ports/345514
> QAT: https://qat.redports.org/buildarchive/r345514/
> 
> Log:
>   libtool 1.4.2a was defining the shared extension as shrext_cmds, rename it shared_ext
>   like in newer libtool so the rest of USES=iconv magic just works
> 
> Modified:
>   head/Mk/Uses/libtool.mk
> 
> Modified: head/Mk/Uses/libtool.mk
> ==============================================================================
> --- head/Mk/Uses/libtool.mk	Fri Feb 21 16:04:38 2014	(r345513)
> +++ head/Mk/Uses/libtool.mk	Fri Feb 21 16:47:29 2014	(r345514)
> @@ -22,7 +22,8 @@ patch-libtool:
>  		-e '/link_all_deplibs[0-9A-Z_]*=/s/=unknown/=no/'	\
>  		-e '/objformat=/s/echo aout/echo elf/'			\
>  		-e "/freebsd-elf\\*)/,/;;/ {				\
> -		    /deplibs_check_method=/s/=.*/=pass_all/; }"
> +		    /deplibs_check_method=/s/=.*/=pass_all/; }"		\
> +		-e "s/shrext_cmds/shared_ext/g"
>  
>  .if ! ${libtool_ARGS:Moldver}
>  	@${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \)	\

Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use
only one name.  shrext_cmds is defined by configure (normally just .so
for us) or by libtool when invoked with -shrext some_extension.  Then
later libtool defines shared_ext using 'eval shared_ext=\"$shrext_cmds\"'.

What port does this fix?



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140221194949.29595e47>