Date: Wed, 7 Sep 2005 09:27:12 -0700 From: "David O'Brien" <obrien@freebsd.org> To: Yar Tikhiy <yar@comp.chem.msu.su> Cc: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>, Poul-Henning Kamp <phk@haven.freebsd.dk>, bug-followup@freebsd.org, freebsd-arch@freebsd.org Subject: Re: kern/85503: panic: wrong dirclust using msdosfs in RELENG_6 Message-ID: <20050907162712.GA3533@dragon.NUXI.org> In-Reply-To: <20050907124411.GB38943@comp.chem.msu.su> References: <35184.1125657474@phk.freebsd.dk> <20050905134006.B73214@atlantis.atlantis.dp.ua> <20050907103416.GB91876@dragon.NUXI.org> <20050907124411.GB38943@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 07, 2005 at 04:44:11PM +0400, Yar Tikhiy wrote: > On Wed, Sep 07, 2005 at 03:34:16AM -0700, David O'Brien wrote: > > On Mon, Sep 05, 2005 at 01:50:01PM +0300, Dmitry Pryanishnikov wrote: > > > ftp://external.atlantis.dp.ua/FreeBSD/PR/85503/msdosfs.patch > > > > > > problem has gone away. Please, if possible, review and commit it. I think > > > this > > > patch is a good MFC candidate for RELENG_6 and RELENG_6_0, since it > > > prevents panic in quite common environment. > > > > I've committed it to HEAD. It is up to the RE's to get it into RELENG_6. > > David, I'm afraid there is certain misunderstanding here. First, > the RE team will hardly take care of getting the fix to RELENG_6 > without your initiative. There is zero misunderstanding here. I'm not going to get into a public debate or fight over this. My experiences to date is that it is too much effort to get all but the most critical bug fixes into a frozen branch. Someone else may take up the MFC during the freeze cause. > Second, the PR kern/85503 shouldn't be > closed until the problem is fixed in all relevant branches: It > should be put in the "patched" state instead according to the > project's well-established policy. Thanks. I've been a FreeBSD committer for almost 10 years now - what you claim is "well established" isn't. When a patch from a PR is committed to head the PR may be closed. The new practice of some committers to change the state to patched is something some committers may like to do, but I don't. The same for the MFC reminder and statement in the commit message is also newer thing that some like to use, but I don't. When I am free to commit to a branch and I have the time to adequately test in the branch, I look for all the commits I've done to HEAD, I do a code merge them and MFC them. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050907162712.GA3533>