Date: Fri, 21 Feb 2014 20:30:04 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r345514 - head/Mk/Uses Message-ID: <20140221193004.GM1699@ithaqua.etoilebsd.net> In-Reply-To: <20140221194949.29595e47@kalimero.tijl.coosemans.org> References: <201402211647.s1LGlTuw053335@svn.freebsd.org> <20140221194949.29595e47@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--NZtAI5QFBF0GmLcW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 21, 2014 at 07:49:49PM +0100, Tijl Coosemans wrote: > On Fri, 21 Feb 2014 16:47:29 +0000 (UTC) Baptiste Daroussin wrote: > > Author: bapt > > Date: Fri Feb 21 16:47:29 2014 > > New Revision: 345514 > > URL: http://svnweb.freebsd.org/changeset/ports/345514 > > QAT: https://qat.redports.org/buildarchive/r345514/ > >=20 > > Log: > > libtool 1.4.2a was defining the shared extension as shrext_cmds, rena= me it shared_ext > > like in newer libtool so the rest of USES=3Diconv magic just works > >=20 > > Modified: > > head/Mk/Uses/libtool.mk > >=20 > > Modified: head/Mk/Uses/libtool.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/Mk/Uses/libtool.mk Fri Feb 21 16:04:38 2014 (r345513) > > +++ head/Mk/Uses/libtool.mk Fri Feb 21 16:47:29 2014 (r345514) > > @@ -22,7 +22,8 @@ patch-libtool: > > -e '/link_all_deplibs[0-9A-Z_]*=3D/s/=3Dunknown/=3Dno/' \ > > -e '/objformat=3D/s/echo aout/echo elf/' \ > > -e "/freebsd-elf\\*)/,/;;/ { \ > > - /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" > > + /deplibs_check_method=3D/s/=3D.*/=3Dpass_all/; }" \ > > + -e "s/shrext_cmds/shared_ext/g" > > =20 > > .if ! ${libtool_ARGS:Moldver} > > @${FIND} ${WRKDIR} \( -name configure -or -name ltconfig \) \ >=20 > Both shrext_cmds and shared_ext exist so I'm not sure it's safe to use > only one name. shrext_cmds is defined by configure (normally just .so > for us) or by libtool when invoked with -shrext some_extension. Then > later libtool defines shared_ext using 'eval shared_ext=3D\"$shrext_cmds\= "'. >=20 > What port does this fix? devel/libghthash is the port broken if you end up with a better fix, please= just commit. Thank you Bapt --NZtAI5QFBF0GmLcW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (FreeBSD) iEYEARECAAYFAlMHqTwACgkQ8kTtMUmk6Ey6UwCffMeE3ieFfA8a2mW0+kL7nesA IrQAnAnciUsnmr3LQDv9SpVCT3WpJ+q0 =MwRB -----END PGP SIGNATURE----- --NZtAI5QFBF0GmLcW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140221193004.GM1699>