Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Sep 2011 03:43:44 +0000 (UTC)
From:      Mark Linimon <linimon@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r225382 - projects/portbuild/scripts
Message-ID:  <201109050343.p853hiLR018990@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: linimon (doc,ports committer)
Date: Mon Sep  5 03:43:43 2011
New Revision: 225382
URL: http://svn.freebsd.org/changeset/base/225382

Log:
  Clean up some comments.

Modified:
  projects/portbuild/scripts/pdispatch

Modified: projects/portbuild/scripts/pdispatch
==============================================================================
--- projects/portbuild/scripts/pdispatch	Mon Sep  5 00:10:37 2011	(r225381)
+++ projects/portbuild/scripts/pdispatch	Mon Sep  5 03:43:43 2011	(r225382)
@@ -102,7 +102,7 @@ case "${chrootdata}" in
 	;;
 esac
 
-#    echo "Got ${chrootdata} from ${host}"
+# echo "Got ${chrootdata} from ${host}"
 
 set -- ${chrootdata}
 if [ $# -ge 2 ]; then
@@ -121,6 +121,7 @@ if [ $# -ge 2 ]; then
 	    # Make sure to close stdin/stderr in the child
 	    # or make will hang until the child process
 	    # exits
+	    # XXX not checking the return value here is why we die with no bindist
 	    ${pbc}/scripts/dosetupnode ${arch} ${branch} ${buildid} ${host} > /tmp/setupnode.$$ 2>&1 &
 	    exit 253
 	    ;;
@@ -204,7 +205,6 @@ fi
 
 ${ssh_cmd} -a -n ${client_user}@${host} ${sudo_cmd} /tmp/${buildid}/scripts/clean-chroot ${arch} ${branch} ${buildid} ${chroot} ${clean}
 
-  # XXX Set a dirty variable earlier and check here
 if grep -q "^build of .*ended at" ${builddir}/logs/${pkgname}.log; then
     exit ${error}
 else



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201109050343.p853hiLR018990>