Date: Thu, 27 Jul 2017 00:45:01 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 221039] uptime/w always show number of users in plural Message-ID: <bug-221039-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221039 Bug ID: 221039 Summary: uptime/w always show number of users in plural Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: timur@FreeBSD.org I've noticed that even when there is only one logged in user in the sustem = the output of uptime/w shows: 2:35AM up 22 days, 9:09, 1 users, load averages: 0.26, 0.24, 0.24 For the FreeBSD 10-STABLE and before it used to be: 12:37AM up 63 days, 12:20, 1 user, load averages: 0.21, 0.14, 0.09 A short dive into the code exposed, that now this output is generated by li= bxo, which is nice, but has more cumbersome syntax: /* Print number of users logged in to system */ xo_emit(" {:users/%d} {N:user%s}", nusers, nusers =3D=3D 1 ? "" : "= s"); Apparenty, for the labels ({N:}) sprintf-like expressions don't work and % = sign is just removed from the label, making label to be always "users". The proper way to express plurals with-in libxo should be: xo_emit(" {:users/%d} {Ngp:user,users}", nusers); according to the http://juniper.github.io/libxo/libxo-manual.html#plural-modifier That handles nusers properly: 0 users 1 user 2 users 101 users In addition, libxo'thication could help with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219113 as well. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-221039-8>