Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 02 Nov 2018 21:21:24 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 229230] newvers falsely appends "-dirty" to hash when building in a git tree with no content changes
Message-ID:  <bug-229230-227-WeLoyJr79s@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-229230-227@https.bugs.freebsd.org/bugzilla/>
References:  <bug-229230-227@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229230

--- Comment #2 from commit-hook@freebsd.org ---
A commit references this bug:

Author: emaste
Date: Fri Nov  2 21:20:46 UTC 2018
New revision: 340083
URL: https://svnweb.freebsd.org/changeset/base/340083

Log:
  newvers.sh: fix git false positive -dirty tag

  Assuming that any output from `git diff-index --name-only` implies
  changes in the working tree results in false positives: files with
  metadata, but not content, changes are also listed.

  Check that content differences exist before adding the -dirty tag to
  the git hash.

  PR:           229230
  Reviewed by:  markj
  Sponsored by: The FreeBSD Foundation
  Differential Revision:        https://reviews.freebsd.org/D15968

Changes:
  head/sys/conf/newvers.sh

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-229230-227-WeLoyJr79s>