Date: Tue, 16 Jul 2002 15:42:23 +0200 (CEST) From: Thomas Zenker <thz@Lennartz-electronic.de> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/40654: patch: sysinstall: infinite loop Message-ID: <200207161342.g6GDgNf9072665@mezcal.tue.le>
next in thread | raw e-mail | index | archive | help
>Number: 40654
>Category: bin
>Synopsis: patch: sysinstall: infinite loop
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jul 16 07:00:03 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Thomas Zenker
>Release: FreeBSD 4.6-RELEASE i386
>Organization:
>Environment:
System: FreeBSD mezcal.tue.le 4.6-RELEASE FreeBSD 4.6-RELEASE #8: Mon Jun 10 11:22:51 CEST 2002 thz@mezcal.tue.le:/usr/obj/usr/src/sys/MEZCAL i386
all versions of sysinstall
>Description:
some errors during scripted partitioning (partionEditor) get
sysinstall looping infinitely, because of use of continue vs.
break in case of error.
>How-To-Repeat:
>Fix:
the following patch applies to current and stable.
Index: label.c
===================================================================
RCS file: /usr/cvs/FreeBSD/src/usr.sbin/sysinstall/label.c,v
retrieving revision 1.118
diff -u -r1.118 label.c
--- label.c 7 Jun 2002 15:32:05 -0000 1.118
+++ label.c 16 Jul 2002 13:27:06 -0000
@@ -1401,7 +1401,7 @@
if (sscanf(cp, "%s %d %s %d", typ, &sz, mpoint, &soft) < 3) {
msgConfirm("For slice entry %s, got an invalid detail entry of: %s", c1->name, cp);
status = DITEM_FAILURE;
- continue;
+ break;
}
else {
Chunk *tmp;
@@ -1422,7 +1422,7 @@
if (sz > space_free(c1)) {
msgConfirm("Not enough free space to create partition: %s", mpoint);
status = DITEM_FAILURE;
- continue;
+ break;
}
if (!(tmp = Create_Chunk_DWIM(d, c1, sz, part,
(type == PART_SWAP) ? FS_SWAP : FS_BSDFFS, flags))) {
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207161342.g6GDgNf9072665>