Date: Thu, 18 Sep 2003 19:19:24 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: jhb@freebsd.org Cc: iwasaki@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci.c src/sys/dev/pci pci.c pci_private.h Message-ID: <20030918.191924.58457370.imp@bsdimp.com> In-Reply-To: <XFMail.20030917105850.jhb@FreeBSD.org> References: <200309170832.h8H8Wii8043278@repoman.freebsd.org> <XFMail.20030917105850.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <XFMail.20030917105850.jhb@FreeBSD.org>
John Baldwin <jhb@freebsd.org> writes:
:
: On 17-Sep-2003 Mitsuru IWASAKI wrote:
: > iwasaki 2003/09/17 01:32:44 PDT
: >
: > FreeBSD src repository
: >
: > Modified files:
: > sys/dev/acpica acpi_pci.c
: > sys/dev/pci pci.c pci_private.h
: > Log:
: > Add pci_resume() to reestablish interrupt routing after
: > suspend/resume.
: > Especially after hibernation, interrupt routing went back to initial
: > status on some machines.
:
: The values in memory should still be the same, so it should be sufficient
: simply to write back the already existent intline value back to the
: register.
:
: IOW, you shouldn't hae to call PCI_ASSIGN_INTERRUPT(), but
: should do something more like:
:
: if (cfg->intpin > 0 && PCI_INTERRUPT_VALID(cfg->intline))
: pci_write_config(child, PCIR_INTLINE, cfg->intline, 1);
:
: Eventually pci_suspend/resume should be saving and restoring all of the
: header registers and known capability registers for child devices.
Yes. These are some of the registers that I'm saving now in my
newcard tree, and also in the power tree we created at bsdcon. The
inline register is just a hint, but an important hint that we use.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030918.191924.58457370.imp>