Date: Wed, 21 Apr 2004 17:21:43 -0700 From: Darren Reed <darrenr@hub.freebsd.org> To: Colin Percival <colin.percival@wadham.ox.ac.uk> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net radix.c Message-ID: <20040422002143.GC60368@hub.freebsd.org> In-Reply-To: <6.0.1.1.1.20040422005919.03afaaa0@imap.sfu.ca> References: <200404211527.i3LFRabS088245@repoman.freebsd.org> <20040421232445.GB60368@hub.freebsd.org> <6.0.1.1.1.20040422005919.03afaaa0@imap.sfu.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 22, 2004 at 01:03:42AM +0100, Colin Percival wrote: > At 00:24 22/04/2004, Darren Reed wrote: > >Some of these changes, for the sake of change, can be annoying... > > As Luigi mentioned when he started this, these aren't changes "for the > sake of change"; rather, these are changes to clean things up so that it > is easier to add all the necessary locking. Uh, really? Changing variable names is required to make locking easier? Changing "x = *(u_char *)p" into "x = LEN(p)" makes locking easier? In the end, if someone decides that the code needs to be restructured for better performance in SMP hardware, then that's what'll happen and changes like these will have little significance at that point in time. Darren
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040422002143.GC60368>