Date: Fri, 31 Aug 2018 08:28:05 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Michael Butler <imb@protected-networks.net> Cc: John Baldwin <jhb@FreeBSD.org>, Ian FREISLICH <ian.freislich@capeaugusta.com>, freebsd-current <freebsd-current@freebsd.org> Subject: Re: intr_machdep.c:176:2: error: use of undeclared identifier 'interrupt_sorted' Message-ID: <20180831052805.GP2340@kib.kiev.ua> In-Reply-To: <8ed7961e-e12a-9267-2bd0-a9bcbe383c7f@protected-networks.net> References: <524214ac-e3ca-53cd-aee3-dac9212e9800@capeaugusta.com> <0aa35f96-9f62-bfca-c04a-f6ddcb1ce738@FreeBSD.org> <8ed7961e-e12a-9267-2bd0-a9bcbe383c7f@protected-networks.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 31, 2018 at 12:21:02AM -0400, Michael Butler wrote: > On 8/29/18 7:40 PM, John Baldwin wrote: > > On 8/29/18 4:20 PM, Ian FREISLICH wrote: > >> Hi > >> > >> I see the definition of interrupt_sorted is #ifdefed out by #ifdef SMP > >> at line 84.š My system is UP <gasp> so I'm not compiling an SMP kernel. > >> > >> /usr/src/sys/x86/x86/intr_machdep.c:176:2: error: use of undeclared > >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? > >> ššššššš interrupt_sorted = mallocarray(num_io_irqs, > >> sizeof(*interrupt_sorted), > >> ššššššš ^~~~~~~~~~~~~~~~ > >> ššššššš interrupt_sources > >> /usr/src/sys/x86/x86/intr_machdep.c:83:24: note: 'interrupt_sources' > >> declared here > >> static struct intsrc **interrupt_sources; > >> šššššššššššššššššššššš ^ > >> /usr/src/sys/x86/x86/intr_machdep.c:176:54: error: use of undeclared > >> identifier 'interrupt_sorted'; did you mean 'interrupt_sources'? > >> ššššššš interrupt_sorted = mallocarray(num_io_irqs, > >> sizeof(*interrupt_sorted), > > > > Probably just needs #ifdef SMP around the mallocarray(). I'll test locallyon a UP kernel config. > > > > I see another problem after using Ian's workaround of moving the #ifdef > SMP; it seems I now run out of kernel stack on an i386 (Pentium-III) > machine with only 512MB of RAM: > > Aug 29 23:29:19 sarah kernel: vm_thread_new: kstack allocation failed > Aug 29 23:29:26 sarah kernel: vm_thread_new: kstack allocation failed > Aug 29 23:29:30 sarah kernel: vm_thread_new: kstack allocation failed > Aug 29 23:29:38 sarah kernel: vm_thread_new: kstack allocation failed > Aug 29 23:29:38 sarah kernel: vm_thread_new: kstack allocation failed > Aug 29 23:29:40 sarah kernel: vm_thread_new: kstack allocation failed What is the kernel revision for "now". What was the previous revision where the kstack allocation failures did not happen. Also, what is the workload ?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180831052805.GP2340>