Date: Fri, 26 May 2000 10:51:55 -0400 (EDT) From: Mike Heffner <mheffner@mailandnews.com> To: Kenji Yabuuchi <yab@astem.or.jp> Cc: freebsd-bugs@FreeBSD.ORG, Gregory Bond <gnb@itga.com.au> Subject: Re: kern/18526: mx does not receive ethernet broadcast packet Message-ID: <XFMail.20000526105155.mheffner@mailandnews.com> In-Reply-To: <200005260613.PAA29126@astemfs.astem.or.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26-May-2000 Kenji Yabuuchi wrote: | >>>>> On Fri, 26 May 2000 15:52:35 +1000, Gregory Bond <gnb@itga.com.au> | >>>>> said: | >> + if (t->mx_did == MX_DEVICEID_987x5) | >> + if (rev != MX_REVISION_98715AEC) | >> + t++; | >> + else if (rev >= MX_REVISION_98725) | >> + t++; | |> Either I'm dense or this is not right (or at the very least, wildly | |> redundant). | |> if (rev != a) t++; | |> else if (rev >= b) t++; | |> makes no sense when a & b are constant. | | Yes, you're right. This part should be: | | if (rev != MX_REVISION_98715AEC || rev >= MX_REVISION_98725) | t++; Could the "rev >= MX_REVISION_98725" be replaced with "MX_REVISION_98715AEC >= MX_REVISION_98725", which would be optimized by the compiler ahead of time. - Mike Heffner <spock@techfour.net> Fredericksburg, VA ICQ# 882073 http://my.ispchannel.com/~mheffner - To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20000526105155.mheffner>