Date: Mon, 09 Sep 2002 17:00:45 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: "Bruce A. Mah" <bmah@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/pkg_install/add main.c Message-ID: <XFMail.20020909170045.jhb@FreeBSD.org> In-Reply-To: <200209092029.g89KTtoM045360@intruder.bmah.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09-Sep-2002 Bruce A. Mah wrote: > If memory serves me right, John Baldwin wrote: > >> On 09-Sep-2002 Bruce A. Mah wrote: >> > bmah 2002/09/09 12:44:17 PDT >> > >> > Modified files: >> > usr.sbin/pkg_install/add main.c >> > Log: >> > Make pkg_install go to the right place for 4.6-RELEASE and 4.6.2-RELEASE >> > packages. >> > >> > Pointed out by: obrien >> > Reviewed by: jhb >> >> Actually, my bad, I think the upper limit for 4.6.2 should likely be 460099, >> not 460100. Other than that, thanks! > > Urk. I just looked over the commit logs for param.h, and you're right, > we should have used 460099 there. > > This would only cause a problem if someone had a pkg_add binary from a > recent 4-STABLE or 4.6-STABLE (i.e. after this commit) but they were > running it on an old 4-STABLE machine that had a __FreeBSD_version of > 460100. Also, 460100 was only in use for 10 hours (plus 40 minutes, and > 17 seconds). I guess I ought to go fix this up though, what do you > think? I would go ahead and just fix it mostly so that in the future we have a more correct example to copy and paste from so we don't propagate the error further in, say, 4.7. :) -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020909170045.jhb>