Date: Wed, 13 Sep 2000 18:58:45 -0700 From: Peter Wemm <peter@netplex.com.au> To: Paul Richards <paul@originative.co.uk> Cc: John Baldwin <jhb@pike.osd.bsdi.com>, "Steven E. Ames" <steve@virtual-voodoo.com>, Gregory Neil Shapiro <gshapiro@gshapiro.net>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/sendmail Makefile Message-ID: <200009140158.e8E1wjG97208@netplex.com.au> In-Reply-To: <39C01B13.2E19971@originative.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Paul Richards wrote:
> Peter Wemm wrote:
> >
> > Paul Richards wrote:
> > > John Baldwin wrote:
> > > >
> > >
> > > > Then you could have things like:
> > > >
> > > > .ifdef(SENDMAIL_USE_SASL)
> > > > SENDMAIL_CFLAGS+=-I/usr/local/include -DSASL
> > > > ...
> > > > .endif
> > > >
> > > > If you wanted to have shortcuts for common extensions. You could stick
> > > > these in either sendmail's Makefile or make.conf. Probably in sendmail
's
> > > > Makefile though.
> > >
> > > More generic would be to add
> > >
> > > .ifdef(USE_SASL)
> > > CFLAGS+=-DSASL -I/usr/local/include/sasl
> > > LDADD+=-L/usr/local/lib -lsasl
> > > .endif
> > >
> > > to the mk file so that other applications will use SASL if USE_SASL is
> > > set in make.conf
> > >
> > > Paul Richards
> > > FreeBSD Services Ltd
> >
> > Except we aren't meant to be hardcoding the paths.
> > eg: /opt/sasl/{include,lib} is supposed to be supported. The build has
> > no business hardcoding /usr/local in it. Yes, I know there are some places
>
> True, the question is then how tied to the ports system should it be?
> The following would work.
>
.ifdef(USE_SASL)
> CFLAGS+=-DSASL -I${LOCALBASE}/include/sasl
> LDADD+=-L${LOCALBASE}/lib -lsasl
> .endif
>
> but that requires LOCALBASE to be visible to the base build system which
> currently it isn't.
You are missing the point.. You are assuming everything is all in the
same /usr/local layout, that is not a valid assumption. LOCALBASE is
equally wrong here as /usr/local. LOCALBASE can be different for each
package as it can be set at pkg_add time. Right now, we support this:
pkg_add -p /opt/sasl sasl-foo.tgz
I personally don't use this today, but did in a previous job. And I know
of a few interesting FreeBSD based sites do things like having /usr/local
being a common NFS mount and /home/local for per-machine stuff.
> Paul Richards
> FreeBSD Services Ltd
>
>
Cheers,
-Peter
--
Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200009140158.e8E1wjG97208>