Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 Oct 2008 07:27:53 +1100
From:      Edwin Groothuis <edwin@mavetju.org>
To:        John Baldwin <john@baldwin.cx>
Cc:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   Re: svn commit: r183899 - user/edwin/top/top-3.8b1/usr.bin/top
Message-ID:  <20081015202753.GO71453@mavetju.org>
In-Reply-To: <200810151054.59231.john@baldwin.cx>
References:  <200810142351.m9ENpUJ4019023@svn.freebsd.org> <200810151054.59231.john@baldwin.cx>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 15, 2008 at 10:54:58AM -0400, John Baldwin wrote:
> On Tuesday 14 October 2008 07:51:30 pm Edwin Groothuis wrote:
> > Author: edwin
> > Date: Tue Oct 14 23:51:30 2008
> > New Revision: 183899
> > URL: http://svn.freebsd.org/changeset/base/183899
> > 
> > Log:
> >   Display the original command between ()'s just like the old top did
> >   when the command and the first argument of the command-line-arguments
> >   don't match.
> >   
> >   According to include/sys/user.h, PS_INMEM is obsoleted in favour
> >   of P_INMEM, not the other way around.
> 
> This change is not quite correct.  You should use P_INMEM for <= 4 and >= 7, 
> and PS_INMEM for >= 5 and <= 6.

Aha, that explains the strange combination of comments I saw in the
include file and the piece of code. Thanks for spotting this!

Edwin
-- 
Edwin Groothuis		Website: http://www.mavetju.org/
edwin@mavetju.org	Weblog:  http://www.mavetju.org/weblog/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081015202753.GO71453>