Date: Wed, 18 Aug 1999 13:40:16 -0500 From: Chris Costello <chris@calldei.com> To: Sheldon Hearn <sheldonh@uunet.co.za> Cc: Brian Feldman <green@FreeBSD.ORG>, hackers@FreeBSD.ORG Subject: Re: cvs commit: src/bin/test test.c Message-ID: <19990818134016.E97181@holly.dyndns.org> In-Reply-To: <15808.934968957@axl.noc.iafrica.com>; from Sheldon Hearn on Wed, Aug 18, 1999 at 11:35:57AM %2B0200 References: <199908180018.RAA84904@freefall.freebsd.org> <15808.934968957@axl.noc.iafrica.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 18, 1999, Sheldon Hearn wrote: > > green 1999/08/17 17:18:53 PDT > > > > Modified files: > > bin/test test.c > > Log: > > The new test(1) did not use access() correctly. I don't know why, since > > supposedly it's ksh-derived, and it's not broken in pdksh. I've added > > a test for test running as root: if testing for -x, the file must be > > mode & 0111 to get "success", rather than just existant. > > > > Reviewed by: chris > > What were you actually trying to fix, here? I didn't see any discussion > of this on hackers, current or bugs, nor in response to my initial > commit message. He was "fixing" (though, as Bruce pointed out, it wasn't a valid fix) test -x. Apparently, access(2) will return 'success' on access(file, X_OK) if called by a program run by root. The patch partly solves the problem, but the euid-vs-ruid problem remains. -- |Chris Costello <chris@calldei.com> |Disc space, the final frontier! `---------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990818134016.E97181>