Date: Tue, 26 Mar 2002 20:38:36 +0000 (UTC) From: "G. Paul Ziemba" <freebsd-net-redist@treehouse.napa.ca.us> To: treehouse-mail-freebsd-net@treehouse.napa.ca.us Subject: should tcp_reass() update tcps_rcvpartduppack, tcps_rcvpartdupbyte? Message-ID: <a7qm8c$1lsh$1@hairball.treehouse.napa.ca.us>
next in thread | raw e-mail | index | archive | help
This is just a nit, but it seems to me that although the code
in tcp_reass() counts completely overlapping packets via the
statistics tcps_rcvduppack and tcps_rcvdupbyte, it does NOT
count partially overlapping packets as it should with
tcps_rcvpartduppack and tcps_rcvpartdupbyte.
I'm thinking that the following change ought to do the
right thing, but I'd like to know if anyone disagrees:
--- tcp_input.c Sat Dec 15 03:23:56 2001
+++ tcp_input.c+ Tue Mar 26 11:04:35 2002
@@ -223,6 +223,9 @@
* completes.
*/
goto present; /* ??? */
+ } else {
+ tcpstat.tcps_rcvpartduppack++;
+ tcpstat.tcps_rcvpartdupbyte += *tlenp;
}
m_adj(m, i);
*tlenp -= i;
--
G. Paul Ziemba paul@w6yx.stanford.edu
FreeBSD unix:
12:36PM up 1 day, 2:44, 9 users, load averages: 0.04, 0.04, 0.01
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a7qm8c$1lsh$1>